Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: replace some cases of strings.SplitN with strings.Cut #1809

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Nov 19, 2023

No description provided.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Merging #1809 (747efda) into master (a076591) will decrease coverage by 0.08%.
Report is 378 commits behind head on master.
The diff coverage is 38.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1809      +/-   ##
==========================================
- Coverage   52.74%   52.67%   -0.08%     
==========================================
  Files         485      485              
  Lines       60537    60536       -1     
==========================================
- Hits        31931    31886      -45     
- Misses      26149    26194      +45     
+ Partials     2457     2456       -1     
Files Coverage Δ
p2p/simulations/http.go 69.48% <100.00%> (-0.63%) ⬇️
rpc/json.go 81.20% <50.00%> (ø)
rpc/service.go 86.20% <40.00%> (ø)
p2p/nat/nat.go 12.63% <0.00%> (ø)

... and 11 files with indirect coverage changes

@ucwong ucwong marked this pull request as ready for review November 19, 2023 11:58
@ucwong ucwong merged commit 0e88ade into master Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants