Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe Api traits #196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Describe Api traits #196

wants to merge 1 commit into from

Conversation

jawoznia
Copy link
Contributor

No description provided.

@jawoznia jawoznia requested a review from uint November 22, 2024 08:45
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmwasm-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:45am

Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This trait was created for the internal use of the generated code to ease the work with the generic
contracts.

<Callout>We reserve the right to break the API of this trait between the minor releases.</Callout>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Callout>We reserve the right to break the API of this trait between the minor releases.</Callout>
<Callout>We reserve the right to break the API of this trait between minor releases.</Callout>

[`ContractApi`](https://docs.rs/sylvia/latest/sylvia/types/trait.ContractApi.html) on the contract
type.

This trait was created for the internal use of the generated code to ease the work with the generic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This trait was created for the internal use of the generated code to ease the work with the generic
This trait was created for internal use of the generated code to ease working with generic

Comment on lines +149 to +150
This trait was created for the internal use of the generated code to ease the work with the generic
contracts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This trait was created for the internal use of the generated code to ease the work with the generic
contracts.
This trait was created for internal use of the generated code to ease working with generic
contracts.

Comment on lines +179 to +180
This trait was created for the internal use of the generated code to ease the work with the generic
contracts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This trait was created for the internal use of the generated code to ease the work with the generic
contracts.
This trait was created for internal use of the generated code to ease working with generic
contracts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants