Add codespace to error acknowledgement #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
add-codespace-ack-error
branch
from
5136a61
to
29ba3e1
Compare
pinosu
approved these changes
Jun 27, 2024
This adds the codespace to error acknowledgements by switching from NewErrorAcknowledgement to NewErrorAcknowledgementWithCodespace. Also creates the initial infrastrucrture to further customize error acknowledgement creation.
webmaster128
force-pushed
the
add-codespace-ack-error
branch
from
29ba3e1
to
51f1634
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1911 +/- ##
=======================================
Coverage 54.88% 54.89%
=======================================
Files 65 65
Lines 9773 9775 +2
=======================================
+ Hits 5364 5366 +2
Misses 3865 3865
Partials 544 544
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the codespace to error acknowledgements by switching from NewErrorAcknowledgement to NewErrorAcknowledgementWithCodespace.
Also creates the initial infrastrucrture to further customize error acknowledgement creation.
Part of #1740