Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying Datasets. #47

Closed
wants to merge 9 commits into from
Closed

Conversation

andrevitorelli
Copy link
Contributor

Closes Issue #46

@andrevitorelli andrevitorelli requested a review from EiffL April 4, 2022 23:44
@andrevitorelli andrevitorelli changed the title Simplifying the Datasets submodule. Simplifying Datasets. Apr 4, 2022
@andrevitorelli
Copy link
Contributor Author

The unit tests have to be modified as the data generator they used won't be available anymore.

@andrevitorelli
Copy link
Contributor Author

It's passing! @EiffL .

This PR simplifies the galgen module, adds a module that creates stamps just like the ngmix test, and removes everything that we weren't using of kimages...

Copy link
Member

@EiffL EiffL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but noted some tiny things easy to fix

tests/test_tf_ngmix.py Outdated Show resolved Hide resolved
tests/test_tf_ngmix.py Show resolved Hide resolved
@andrevitorelli andrevitorelli requested a review from EiffL April 27, 2022 07:29
@andrevitorelli
Copy link
Contributor Author

Closed for reorganization of development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants