-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic Docker Builds #695
base: develop
Are you sure you want to change the base?
Conversation
… there doesn't seem to be a failsafe way to lowercase a string in github actions)
…(which currently takes 50% of the build time)
@martinkilbinger please feel free to merge if you're happy with this, the shapepipe test script now gets run in the container upon commit. You can look at "Tests" here if you'd like to see this in action :) |
Actually, one thing I didn't do is check that my changes to the docs rendered properly.. I'm worried that the docs-building with conda is also broken, and that I'll need to move that workflow from conda to docker as well. Maybe @sfarrens can comment.. is |
Summary
install_shapepipe
and conda environment variables obsolete, but I'm not quite ready to invest the time to de-condify the docs.__installs__
import inrun.py
This could potentially close a several issues related to dependency issues on canfar/candide.
Reviewer Checklist
develop
branch