Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18] x/FeePay Module #808

Merged
merged 85 commits into from
Oct 24, 2023
Merged

[v18] x/FeePay Module #808

merged 85 commits into from
Oct 24, 2023

Conversation

Reecepbcups
Copy link
Contributor

@Reecepbcups Reecepbcups commented Aug 24, 2023 •
edited
Loading

Closes #787

FeePrepay allows contract devs to pay for the Tx Fees for executing on their contracts.
Useful for

  • user experience
  • Fully on chain Faucets
  • Returning FeeShare income back to users of the apps (ex: 50% rebate)

Design Phases

  • POC (Modify deduct fee to pay for a users Tx if 0 fee is specifid (hide globalfee for now))
  • Stage 1: Base module. Pay for Txs via the feeprepay module account
  • Stage 2: Make it so a contract admin/creator can upload fees for their contract to be paid. Also allow them to set number of fee Txs an account gets
  • Stage 3: Testing
  • Stage 4: Re-add globlafee in ante and validate testing still passes

v2: allow users to prepay their own Tx fees

@joelsmith-2019
Copy link
Contributor

Attaching General Flow Chart Here:
image

joelsmith-2019 and others added 14 commits August 29, 2023 17:13
@Reecepbcups
Copy link
Contributor Author

Solid update in 5101407, nice work!

@joelsmith-2019
Implement Contract Query Pagination
5a94316
@joelsmith-2019
Code cleanup,
c89e7aa 
Register fee pay errors
@joelsmith-2019
Implement wallet limits,
8090a8e 
Update ante to deduct contract balance
@joelsmith-2019
Query if wallet is eligible,
81d0e01 
Add admin checks on contract registration
@joelsmith-2019
Improve ante error messages
3e85261
@Reecepbcups Reecepbcups marked this pull request as ready for review October 17, 2023 14:03
@Reecepbcups Reecepbcups added the review me Review me for merge label Oct 23, 2023
@Reecepbcups Reecepbcups changed the title [v18] x/FeePrepay Module [v18] x/FeePay Module Oct 24, 2023
@Reecepbcups
Copy link
Contributor Author

works locally, merging :D

@Reecepbcups Reecepbcups merged commit 7c67450 into main Oct 24, 2023
4 checks passed
@joelsmith-2019 joelsmith-2019 deleted the joel_fee-prepay branch February 2, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelsmith-2019 joelsmith-2019 joelsmith-2019 left review comments

@dimiandre dimiandre dimiandre approved these changes

@the-frey the-frey Awaiting requested review from the-frey

@JakeHartnell JakeHartnell Awaiting requested review from JakeHartnell JakeHartnell is a code owner

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees

@joelsmith-2019 joelsmith-2019

Labels
review me Review me for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Fee-Prepay module
3 participants
@Reecepbcups @joelsmith-2019 @dimiandre