Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IAVL v0.20.1 & Fix Concurrency issue on mainnet #826

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Use IAVL v0.20.1 & Fix Concurrency issue on mainnet #826

merged 1 commit into from
Sep 6, 2023

Conversation

mattverse
Copy link
Contributor

@mattverse mattverse commented Sep 6, 2023 •
edited
Loading

Currently Juno nodes would run into the following error once in a while with node halting:

�[90m12:54PM�[0m �[32mINF�[0m executed block �[36mheight=�[0m9522889 �[36mmodule=�[0mstate �[36mnum_invalid_txs=�[0m0 �[36mnum_valid_txs=�[0m3 �[36mserver=�[0mnode
fatal error: concurrent map iteration and map write

goroutine 963386 [running]:
runtime.throw({0x27ef174?, 0x8?})
	runtime/panic.go:992 +0x71 fp=0xc0a2e49fb0 sp=0xc0a2e49f80 pc=0x43f0b1
runtime.mapiternext(0xc0a2e4a0a0?)

The new IAVL patch that has been made fixes this, this change is non-state breaking.
A new minor version release once this is merged is recommended in order to fix concurrency problems in mainnet

@Reecepbcups Reecepbcups mentioned this pull request Sep 6, 2023
Merged
@Reecepbcups Reecepbcups merged commit 78b81c5 into CosmosContracts:main Sep 6, 2023
15 checks passed
Reecepbcups added a commit that referenced this pull request Sep 19, 2023
@Reecepbcups @mattverse @joelsmith-2019
DNM: [uni-a] Standalone Upgrade Patch for Testnet (#821)
d307dff 
* uni-a standalone upgrade

* 100m tokens from 1m (oops, thanks dimi!)

* make it easier to read

* Use IAVL v0.20.1 (#826)

* v17: Migrate SubDAOs from distribution module -> gov (#831)

* migrateChainOwnedSubDaos from distr -> gov

* lint

* simplify addr logic

* minor: comment typo

* Fix v17 Upgrade Package Name (#832)

* chore: ci bumps (#840)

---------

Co-authored-by: Matt, Park <[email protected]>
Co-authored-by: Joel Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reecepbcups Reecepbcups Reecepbcups approved these changes

@the-frey the-frey Awaiting requested review from the-frey

@JakeHartnell JakeHartnell Awaiting requested review from JakeHartnell JakeHartnell is a code owner

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@dimiandre dimiandre Awaiting requested review from dimiandre dimiandre is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattverse @Reecepbcups