[v18] FeeShare: Allow authz exec to count towards feeshare payouts #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reecepbcups
requested review from
the-frey,
JakeHartnell,
jackzampolin and
dimiandre
as code owners
JakeHartnell
approved these changes
Sep 20, 2023
aleem1314
reviewed
Sep 25, 2023
| @@ -62,29 +63,63 @@ type FeeSharePayoutEventOutput struct { | |||
| FeesPaid sdk.Coins `json:"fees_paid"` | |||
| } | |||
|
|
|||
| func addNewFeeSharePayoutsForMsg(ctx sdk.Context, fsk FeeShareKeeper, toPay *[]sdk.AccAddress, m sdk.Msg) error { | |||
| if msg, ok := m.(*wasmtypes.MsgExecuteContract); ok { | |||
There was a problem hiding this comment.
If the message contains another authz.MsgExec this logic doesn't work. You should add additional case for authz.MsgExec, and if it contains another authz.MsgExec message, call the function recursively.
aleem1314
reviewed
Sep 25, 2023
| validAuthz := func(execMsg *authz.MsgExec) error { | ||
| for _, v := range execMsg.Msgs { | ||
| var innerMsg sdk.Msg | ||
| if err := json.Unmarshal(v.Value, &innerMsg); err != nil { |
There was a problem hiding this comment.
I think this is always going to fail. You should use SDK codec to correctly unmarshal any type to an interface.
There was a problem hiding this comment.
To add on to what aleem is saying, It turns out authz.MsgExec has a built in function called "GetMessages()" which returns an arrray of sdk.Msg. Way easier than looping through and trying to unmarshal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Aleem from Vitwit for pointing this out :)
summary
Allows feeshare authz executes to pay the wasm contract its % of feeshare rewards.
(Reuses logic from past decorator in v14.0.0)