Api group model completion #650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added edit section to Bio to enter social media links.
…s social media sites.
…Serializer to accomodate writing to nested tables.
0xZakk
suggested changes
Jul 6, 2020
There was a problem hiding this comment.
@secondaryfun This looks pretty good! Really impressive so far.
A few more things for you to figure out:
- You have it so that a location has a group, but you want that the other way (a group belongs to a location). Under the current setup, there can only be 1 group in a location, but just like in meetup, we want to potentially have lots of groups related to a location.
- Can you update the fixtures to reflect these changes to the data? I.e. if a Post has to belong to a group, then can you add a group ID to the posts fixtures?
- It looks like the changes from your other PR are in this one too, can you get rid of those changes from this PR? I.e. the changes to Bio.css, Bio.js, Icon.js, TextInputField.js, etc
|
Resubmitted with different branch. |
0xZakk
pushed a commit
that referenced
this pull request
Jul 7, 2020
Resubmit - Api group model completion #650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue (include '#'): Group Model Update - Create connections for group functionality. #649
Description of changes made:
Location: one-to-many relationship to Group added on Location Model
Profile: many-to-many relationship to Group added on Profile Model
Posts: one-to-many relationship to Group added on Post Model
Is the feature complete/bug resolved/etc..: yes
Any known bugs/strange behavior: no
Is there specific feedback you would like on these changes:
Please check logic for "on_delete":
Post Model - on_delete=models.CASCADE
Location Model - on_delete=models.PROTECT
Profile - blank
Screenshot(s):
Profile: