Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubmit - Api group model completion #650 #651

Merged
merged 6 commits into from
Jul 7, 2020
Merged

Conversation

secondaryfun
Copy link
Contributor

Location: one-to-many relationship to Group added on Location Model
Profile: many-to-many relationship to Group added on Profile Model
Posts: one-to-many relationship to Group added on Post Model

  • Is the feature complete/bug resolved/etc..: yes

  • Any known bugs/strange behavior: no

  • Is there specific feedback you would like on these changes:

Please check logic for "on_delete":

  • Post Model - on_delete=models.CASCADE

  • Location Model - on_delete=models.PROTECT

  • Profile - blank

  • Screenshot(s):
    image
    image
    Profile:
    image

@secondaryfun
Copy link
Contributor Author

From Zakk on previous PR:

You have it so that a location has a group, but you want that the other way (a group belongs to a location). Under the current setup, there can only be 1 group in a location, but just like in meetup, we want to potentially have lots of groups related to a location.

  • DONE
    Can you update the fixtures to reflect these changes to the data? I.e. if a Post has to belong to a group, then can you add a group ID to the posts fixtures?

  • DONE
    It looks like the changes from your other PR are in this one too, can you get rid of those changes from this PR? I.e. the changes to Bio.css, Bio.js, Icon.js, TextInputField.js, etc

  • Error on the original branch. Resubmitted using this branch.

Copy link
Contributor

@0xZakk 0xZakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@secondaryfun This looks good!

@0xZakk 0xZakk merged commit 7957f4b into develop Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants