Adding improvements (missed things) (#33)

* Updating SDK versions. Fixing test bug. * Updated JSON library version from "20180813" to "20230227" * Deprecating config calls * Missed things
Countly · Mar 6, 2023 · 1517ff8 · 1517ff8
1 parent 1b4445d
commit 1517ff8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 19 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,9 @@
   - "setDeviceIdFallbackAllowed"
   - "overrideModule"
   - "getModuleOverride"
+  - "getCrashReportingANRCheckingPeriod"
+  - "setCrashReportingANRCheckingPeriod"
+  - "disableANRCrashReporting"
 * ! Minor breaking change ! The "TestMode" functionality is being removed from the SDK.
 * ! Minor breaking change ! The module override functionality is being removed from the SDK.
 * ! Minor breaking change ! It is not possible to set the logging tag anymore.

diff --git a/sdk-java/src/main/java/ly/count/sdk/java/Config.java b/sdk-java/src/main/java/ly/count/sdk/java/Config.java
@@ -385,14 +385,6 @@ public boolean restore(byte[] data) {
      */
     protected int sessionAutoCloseAfter = "Android".equals(System.getProperty("os.name")) ? 10 : 0;
 
-    /**
-     * When not {@code null}, more than {@code 0} and {@code Feature.CrashReporting} is enabled,
-     * Countly watches main thread for unresponsiveness.
-     * When main thread doesn't respond for time more than this property in seconds,
-     * SDK reports ANR crash back to Countly server.
-     */
-    protected int crashReportingANRCheckingPeriod = 5;
-
     /**
      * {@link CrashProcessor}-implementing class which is instantiated when application
      * crashes or crash is reported programmatically using {@link Session#addCrashReport(Throwable, boolean, String, Map, String...)}.
@@ -1110,24 +1102,19 @@ public Config addCertificatePin(String pemEncodedCertificate) {
      * To disable ANR reporting, use {@link #disableANRCrashReporting()}.
      *
      * @param periodInSeconds how much time the SDK waits between individual ANR checks
+     * @deprecated will do nothing
      * @return {@code this} instance for method chaining
      */
     public Config setCrashReportingANRCheckingPeriod(int periodInSeconds) {
-        if (periodInSeconds < 0) {
-            System.out.print("[ConfigCore] ANR timeout less than zero doesn't make sense");
-        } else {
-            this.crashReportingANRCheckingPeriod = periodInSeconds;
-        }
         return this;
     }
 
     /**
      * Disable ANR detection and thus reporting to Countly server.
-     *
+     * @deprecated will do nothing
      * @return {@code this} instance for method chaining
      */
     public Config disableANRCrashReporting() {
-        this.crashReportingANRCheckingPeriod = 0;
         return this;
     }
 
@@ -1516,11 +1503,11 @@ public Set<String> getCertificatePins() {
 
     /**
      * Getter for {@link #crashReportingANRCheckingPeriod}
-     *
+     * @Deprecated will always return "5"
      * @return {@link #crashReportingANRCheckingPeriod} value
      */
     public int getCrashReportingANRCheckingPeriod() {
-        return crashReportingANRCheckingPeriod;
+        return 5;
     }
 
     /**

diff --git a/sdk-java/src/main/java/ly/count/sdk/java/internal/InternalConfig.java b/sdk-java/src/main/java/ly/count/sdk/java/internal/InternalConfig.java
@@ -142,7 +142,7 @@ public byte[] store() {
             stream.writeInt(eventsBufferSize);
             stream.writeInt(sessionCooldownPeriod);
             stream.writeBoolean(false);//for keeping backwards compatibility, remove in the future
-            stream.writeInt(crashReportingANRCheckingPeriod);
+            stream.writeInt(5);//for keeping backwards compatibility, remove in the future (crashReportingANRCheckingPeriod)
             stream.writeObject(crashProcessorClass);
             stream.writeInt(moduleOverrides == null ? 0 : moduleOverrides.size());
             if (moduleOverrides != null && moduleOverrides.size() > 0) {
@@ -231,7 +231,7 @@ public boolean restore(byte[] data) {
             eventsBufferSize = stream.readInt();
             sessionCooldownPeriod = stream.readInt();
             boolean throwawayCountlyTestMode = stream.readBoolean();//we are only reading this for backwards compatibility. Throw away in the future
-            crashReportingANRCheckingPeriod = stream.readInt();
+            int throwawayCrashReportingANRCheckingPeriod = stream.readInt();//we are only reading this for backwards compatibility. Throw away in the future. crashReportingANRCheckingPeriod
             crashProcessorClass = (String) stream.readObject();
 
             l = stream.readInt();