Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Add new device ID module tests add device ID type to scenario tests #161

Merged
merged 42 commits into from
Nov 10, 2023
Merged

[Java] Add new device ID module tests add device ID type to scenario tests #161

merged 42 commits into from
Nov 10, 2023

Conversation

arifBurakDemiray
Copy link
Member

No description provided.

arifBurakDemiray and others added 22 commits November 6, 2023 16:43
@arifBurakDemiray
feat: new device id change callback
1be0102
@arifBurakDemiray
feat: call after onDeviceId
8bf3cc4
@arifBurakDemiray
refactor: usage of device id changed in module device id
44b30a8
@ArtursKadikis
Merge branch 'staging' into device_id_change_callback
d670b66
@arifBurakDemiray
Merge branch 'staging' into device_id_change_callback
10e74a7
@arifBurakDemiray
feat: did changes
d9958b6
@arifBurakDemiray
feat: add device id type to scenario tests
796fb3c
@arifBurakDemiray
fix: tests
bd74867
@arifBurakDemiray
revert: scenario changes
0297c91
@arifBurakDemiray
feat: missing comments
d3e4511
@arifBurakDemiray
feat: new device id module calls to scenarioo device id tests
61a1ee5
@arifBurakDemiray
feat: missing changelog
dbe24ec
@arifBurakDemiray
fix: update existing tests
b9bba53
@arifBurakDemiray
fix: add check to callback
fb18a22
@arifBurakDemiray
refactor: remove unnecessary callback
c69c9d3
@arifBurakDemiray
feat: test ccases
000babd
@arifBurakDemiray
fix: login and logout
2163fb8
@arifBurakDemiray
refactor: device id module
7f35e6b
@arifBurakDemiray
Merge pull request #159 from Countly/device_id_change_callback
1cfb461 
fix: login and logout
@arifBurakDemiray
fix: remove unnecessary params
c29de07
@arifBurakDemiray
feat: new tests
91f25b5
@arifBurakDemiray
fix: rq access index
e2d7ed4
@arifBurakDemiray
Copy link
Member Author

[Java] Add new device ID module tests add device ID type to scenario tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited
Loading

Unit Test Results 🚀

313 tests  +17   312 ✔️ +17   14s ⏱️ +5s
  26 suites ±  0       0 💤 ±  0 
  26 files   ±  0       1 ❌ ±  0 

For more details on these failures, see this check.

Results for commit 4dfbcbf. ± Comparison against base commit 3ac8fa1.

♻️ This comment has been updated with latest results.

@arifBurakDemiray arifBurakDemiray marked this pull request as ready for review November 9, 2023 11:16
ArtursKadikis
ArtursKadikis requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should validate the specific requests and the order of requests in the RQ after changing device ID's

The internal helpers should get comments to better document their usage and intended purpose.

Think about how to have stronger assertion about the code execution for device ID merging

@ArtursKadikis ArtursKadikis merged commit 0245a56 into staging Nov 10, 2023
@ArtursKadikis ArtursKadikis deleted the tests_for_deviceid_module branch November 10, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtursKadikis ArtursKadikis Awaiting requested review from ArtursKadikis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arifBurakDemiray @ArtursKadikis