Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] fix question mark issue when getting available feedback widget list #168

Merged
merged 3 commits into from
Nov 15, 2023
Merged

[Java] fix question mark issue when getting available feedback widget list #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dab5bb8
fix: change location of question mark
arifBurakDemiray Nov 15, 2023
04f6671
fix: feedback widget qmark
arifBurakDemiray Nov 15, 2023
20320c0
Update CHANGELOG.md
ArtursKadikis Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 23.10.1

* Fixed a bug where getting the feedback widget list would fail if "salt" was enabled.

## 23.10.0

* ! Minor breaking change ! Calling "init" twice will now not reinitialize the SDK. The call will be ignored
Expand Down
2 changes: 1 addition & 1 deletion sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleFeedback.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ private void getAvailableFeedbackWidgetsInternal(CallbackOnFinish<List<CountlyFe
String params = ModuleRequests.prepareRequiredParamsAsString(internalConfig, "method", "feedback");
ImmediateRequestGenerator iRGenerator = internalConfig.immediateRequestGenerator;

iRGenerator.createImmediateRequestMaker().doWork("?" + params, "/o/sdk", transport, false, networkingIsEnabled, checkResponse -> {
iRGenerator.createImmediateRequestMaker().doWork(params, "/o/sdk?", transport, false, networkingIsEnabled, checkResponse -> {
if (checkResponse == null) {
L.d("[ModuleFeedback] getAvailableFeedbackWidgetsInternal, Not possible to retrieve widget list. Probably due to lack of connection to the server");
callback.onFinished(null, "Not possible to retrieve widget list. Probably due to lack of connection to the server");
Expand Down
2 changes: 1 addition & 1 deletion sdk-java/src/test/java/ly/count/sdk/java/internal/ModuleFeedbackTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ public void getAvailableFeedbackWidgets_base(List<CountlyFeedbackWidget> expecte
ImmediateRequestI requestMaker = (requestData, customEndpoint, cp, requestShouldBeDelayed, networkingIsEnabled, callback, log) -> {
Map<String, String> params = TestUtils.parseQueryParams(requestData);
Assert.assertEquals("feedback", params.get("method"));
TestUtils.validateRequestMakerRequiredParams("/o/sdk", customEndpoint, requestShouldBeDelayed, networkingIsEnabled);
TestUtils.validateRequestMakerRequiredParams("/o/sdk?", customEndpoint, requestShouldBeDelayed, networkingIsEnabled);
TestUtils.validateRequiredParams(params);
callback.callback(returnedResponse);
};
Expand Down
Loading