Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Add location module #172

Merged
merged 21 commits into from
Dec 4, 2023
Merged

[Java] Add location module #172

merged 21 commits into from
Dec 4, 2023

Conversation

arifBurakDemiray
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited
Loading

Unit Test Results 🚀

379 tests  +13   369 ✔️ +12   23s ⏱️ +8s
  31 suites +  2       0 💤 ±  0 
  31 files   +  2     10 ❌ +  1 

For more details on these failures, see this check.

Results for commit f0c1f5d. ± Comparison against base commit 9b4ba3c.

♻️ This comment has been updated with latest results.

@arifBurakDemiray arifBurakDemiray marked this pull request as ready for review November 20, 2023 12:07
@arifBurakDemiray arifBurakDemiray marked this pull request as draft November 20, 2023 12:07
@ArtursKadikis ArtursKadikis marked this pull request as ready for review November 21, 2023 13:03
@ArtursKadikis ArtursKadikis changed the base branch from master to staging November 21, 2023 13:03
ArtursKadikis
ArtursKadikis requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "disable loc" and set location for the config object

ArtursKadikis
ArtursKadikis requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implement example scenarios in tests

@ArtursKadikis ArtursKadikis merged commit 67dfbfb into staging Dec 4, 2023
1 check failed
@ArtursKadikis ArtursKadikis deleted the new_location_module branch December 4, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtursKadikis ArtursKadikis ArtursKadikis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arifBurakDemiray @ArtursKadikis