Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder_sdkcore #217

Merged
merged 1 commit into from
Jan 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 72 additions & 60 deletions sdk-java/src/main/java/ly/count/sdk/java/internal/SDKCore.java
Original file line number Diff line number Diff line change
Expand Up @@ -379,54 +379,6 @@ public SessionImpl getSession() {
return null;
}

public ModuleFeedback.Feedback feedback() {

if (!hasConsentForFeature(CoreFeature.Feedback)) {
L.v("[SDKCore] feedback, Feedback feature has no consent, returning null");
return null;
}

return module(ModuleFeedback.class).feedbackInterface;
}

public ModuleCrashes.Crashes crashes() {
if (!hasConsentForFeature(CoreFeature.CrashReporting)) {
L.v("[SDKCore] crash, Crash Reporting feature has no consent, returning null");
return null;
}

return module(ModuleCrashes.class).crashInterface;
}

public ModuleDeviceIdCore.DeviceId deviceId() {
return module(ModuleDeviceIdCore.class).deviceIdInterface;
}

public ModuleRemoteConfig.RemoteConfig remoteConfig() {
if (!hasConsentForFeature(CoreFeature.RemoteConfig)) {
L.v("[SDKCore] remoteConfig, RemoteConfig feature has no consent, returning null");
return null;
}

return module(ModuleRemoteConfig.class).remoteConfigInterface;
}

public ModuleUserProfile.UserProfile userProfile() {
return module(ModuleUserProfile.class).userProfileInterface;
}

public ModuleLocation.Location location() {
if (!hasConsentForFeature(CoreFeature.Location)) {
L.v("[SDKCore] location, Location feature has no consent, returning null");
return null;
}
ModuleLocation module = module(ModuleLocation.class);
if (module == null) {
return null;
}
return module.locationInterface;
}

/**
* Get current {@link SessionImpl} or create new one if current is {@code null}.
*
Expand Down Expand Up @@ -581,18 +533,6 @@ public UserImpl user() {
return user;
}

/**
* @return timedEvents interface
* @deprecated use {@link ModuleEvents.Events#startEvent(String)} instead via <code>instance().events()</code> call
*/
TimedEvents timedEvents() {
return ((ModuleSessions) module(CoreFeature.Sessions.getIndex())).timedEvents();
}

public ModuleEvents.Events events() {
return ((ModuleEvents) module(CoreFeature.Events.getIndex())).eventsInterface;
}

public InternalConfig config() {
return config;
}
Expand Down Expand Up @@ -757,4 +697,76 @@ private boolean processCrash(InternalConfig config, Long id) {
public void onRequest(InternalConfig config, Request request) {
onSignal(config, SDKCore.Signal.Ping.getIndex(), null);
}

//Module functions

/**
* @return timedEvents interface
* @deprecated use {@link ModuleEvents.Events#startEvent(String)} instead via <code>instance().events()</code> call
*/
TimedEvents timedEvents() {
return ((ModuleSessions) module(CoreFeature.Sessions.getIndex())).timedEvents();
}

public ModuleEvents.Events events() {
if (!hasConsentForFeature(CoreFeature.Events)) {
L.v("[SDKCore] events, Events feature has no consent, returning null");
return null;
}

ModuleEvents module = module(ModuleEvents.class);
if (module == null) {
return null;
}

return module.eventsInterface;
}

public ModuleFeedback.Feedback feedback() {

if (!hasConsentForFeature(CoreFeature.Feedback)) {
L.v("[SDKCore] feedback, Feedback feature has no consent, returning null");
return null;
}

return module(ModuleFeedback.class).feedbackInterface;
}

public ModuleCrashes.Crashes crashes() {
if (!hasConsentForFeature(CoreFeature.CrashReporting)) {
L.v("[SDKCore] crash, Crash Reporting feature has no consent, returning null");
return null;
}

return module(ModuleCrashes.class).crashInterface;
}

public ModuleDeviceIdCore.DeviceId deviceId() {
return module(ModuleDeviceIdCore.class).deviceIdInterface;
}

public ModuleRemoteConfig.RemoteConfig remoteConfig() {
if (!hasConsentForFeature(CoreFeature.RemoteConfig)) {
L.v("[SDKCore] remoteConfig, RemoteConfig feature has no consent, returning null");
return null;
}

return module(ModuleRemoteConfig.class).remoteConfigInterface;
}

public ModuleUserProfile.UserProfile userProfile() {
return module(ModuleUserProfile.class).userProfileInterface;
}

public ModuleLocation.Location location() {
if (!hasConsentForFeature(CoreFeature.Location)) {
L.v("[SDKCore] location, Location feature has no consent, returning null");
return null;
}
ModuleLocation module = module(ModuleLocation.class);
if (module == null) {
return null;
}
return module.locationInterface;
}
}