[Java] Complete the feedback widget module #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtursKadikis
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Let's pull out unrelated things we can merge first
Let's add a test for ModuleFeedback.parseFeedbackList( with garbage input and empty string
add a test for getAvailableFeedbackWidgets where the request returns a random JSON
Add tests for :
- getFeedbackWidgetData
- reportFeedbackWidgetManually
lets put the "addRequiredTimeParams" changes into a separate PR
For the feedback tests, add tests that validate the attempted request params
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleFeedback.java
Outdated
Show resolved
Hide resolved
refactor: event size queue check
…ountly-sdk-java into create_feedback_module
…into create_feedback_module
arifBurakDemiray
added a commit
that referenced
this pull request
Oct 4, 2023
[Java] Complete the feedback widget module (#76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.