Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive widget support #13

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Responsive widget support #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a68d7d
supportr
turtledreams Apr 4, 2024
f238494
rem
turtledreams Apr 4, 2024
bd53fa0
c
turtledreams Apr 8, 2024
1c6b61b
cc
turtledreams Apr 8, 2024
39b0fd8
moved
turtledreams Apr 23, 2024
27f1d29
version update
turtledreams Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 24.4.0

* Added support for Feedback Widgets' terms and conditions

## 23.12.6

* Mitigated an issue where error tracking could prevent SDK initialization in async mode
Expand Down
2 changes: 1 addition & 1 deletion modules/Constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ var healthCheckCounterEnum = Object.freeze({
errorMessage: "cly_hc_error_message",
});

var SDK_VERSION = "23.12.5";
var SDK_VERSION = "24.4.0";
var SDK_NAME = "javascript_native_web";

// Using this on document.referrer would return an array with 17 elements in it. The 12th element (array[11]) would be the path we are looking for. Others would be things like password and such (use https://regex101.com/ to check more)
Expand Down
5 changes: 3 additions & 2 deletions modules/CountlyClass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3061,11 +3061,12 @@ class CountlyClass {
url += "&platform=" + this.platform;
url += "&app_version=" + this.app_version;
url += "&sdk_version=" + sdkVersion;
var customObjectToSendWithTheWidget = {};
customObjectToSendWithTheWidget.tc = 1; // indicates SDK supports opening links from the widget in a new tab
if (feedbackWidgetSegmentation) {
var customObjectToSendWithTheWidget = {};
customObjectToSendWithTheWidget.sg = feedbackWidgetSegmentation;
url += "&custom=" + JSON.stringify(customObjectToSendWithTheWidget);
}
url += "&custom=" + JSON.stringify(customObjectToSendWithTheWidget);
// Origin is passed to the popup so that it passes it back in the postMessage event
// Only web SDK passes origin and web
url += "&origin=" + passedOrigin;
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "countly-sdk-js",
"version": "23.12.5",
"version": "24.4.0",
"description": "Countly JavaScript SDK",
"type": "module",
"main": "Countly.js",
Expand Down
Loading