Added a way to explicity process the async queue #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtursKadikis
requested changes
Jan 20, 2024
modules/CountlyClass.js
Outdated
| @@ -3445,6 +3452,7 @@ class CountlyClass { | |||
| * Check and send the events to request queue if there are any, empty the event queue | |||
| */ | |||
| function sendEventsForced() { | |||
| processAsyncQueue(); // process async queue before sending events | |||
There was a problem hiding this comment.
this is the wrong place to put this in.
It is a totally underlated operation from "sendEventsForced"
why does the "process all async operations assigned to the SDK" have to be tied into the "package all events into a request" call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.