Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk Tests #101

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Bulk Tests #101

merged 3 commits into from
Sep 19, 2024

Conversation

AliRKat
Copy link

@AliRKat AliRKat commented Sep 3, 2024

No description provided.

arifBurakDemiray
arifBurakDemiray reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@arifBurakDemiray arifBurakDemiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe more request types would be a great touch like crashes, feedback, views, APM etc

test/tests_bulk.js Outdated Show resolved Hide resolved
@AliRKat
Copy link
Author

AliRKat commented Sep 4, 2024

[NodeJS] Bulk Tests

turtledreams
turtledreams requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@turtledreams turtledreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one. recommended some changes to reduce complexity. lets do those if we can and move on to storage again.

test/helpers/helper_functions.js Outdated Show resolved Hide resolved
test/tests_bulk.js Show resolved Hide resolved
test/helpers/helper_functions.js Outdated Show resolved Hide resolved
@turtledreams turtledreams merged commit 97a4ccc into staging Sep 19, 2024
5 of 6 checks passed
@turtledreams turtledreams deleted the BulkTests branch September 19, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arifBurakDemiray arifBurakDemiray arifBurakDemiray approved these changes

@ijunaid ijunaid Awaiting requested review from ijunaid

@peterBrxwn peterBrxwn Awaiting requested review from peterBrxwn

@turtledreams turtledreams Awaiting requested review from turtledreams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AliRKat @arifBurakDemiray @turtledreams