Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Only Storage Option #102

Merged
merged 14 commits into from
Oct 3, 2024
Merged

Memory Only Storage Option #102

merged 14 commits into from
Oct 3, 2024

Conversation

AliRKat
Copy link

@AliRKat AliRKat commented Sep 18, 2024

No description provided.

@AliRKat AliRKat added the draft label Sep 19, 2024
@AliRKat AliRKat removed the draft label Sep 19, 2024
@AliRKat
Copy link
Author

AliRKat commented Sep 19, 2024

[NodeJS] Option to use memory only for storage

arifBurakDemiray
arifBurakDemiray approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@arifBurakDemiray arifBurakDemiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ganabtte!

turtledreams
turtledreams requested changes Sep 25, 2024
View reviewed changes
lib/countly-bulk.js Outdated Show resolved Hide resolved
test/tests_storage.js Outdated Show resolved Hide resolved
@AliRKat AliRKat requested a review from turtledreams October 1, 2024 15:14
turtledreams
turtledreams requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@turtledreams turtledreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify that persistent storage folder is empty in memory tests

Ali Rıza Kat added 3 commits October 3, 2024 00:22
Bug Fix Testing
ddf942b
Update tests_internal_limits.js
9cb8700 
these were failing for a reason, updated the checks
Changelog update
4dfbaa7
@AliRKat AliRKat requested a review from turtledreams October 2, 2024 21:34
turtledreams
turtledreams requested changes Oct 3, 2024
View reviewed changes
lib/countly-storage.js Outdated Show resolved Hide resolved
@AliRKat AliRKat requested a review from turtledreams October 3, 2024 06:57
@turtledreams turtledreams merged commit 9f3f490 into staging Oct 3, 2024
5 of 6 checks passed
@turtledreams turtledreams deleted the MemoryOnlyStorage branch October 3, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arifBurakDemiray arifBurakDemiray arifBurakDemiray approved these changes

@ijunaid ijunaid Awaiting requested review from ijunaid

@turtledreams turtledreams Awaiting requested review from turtledreams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AliRKat @arifBurakDemiray @turtledreams