Language and mathematical standardizations #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd slightly refactored "step" to have only one "return" statement
…merization. Pytest should now catch and run the former
… next. pytest run time was 1.35 s prior to this change.
…on_stoichiometry or just stoichiometry depending on context)
…ich seems to be an improvement
There was a problem hiding this comment.
Hey @jmason42, looks good, thanks for setting this up! Though I see we clash on a few stylistic/semantic points. Let's resolve these in a copacetic way : )
|
These changes should address your concerns. I went with |
|
Awesome, thanks for this! I'll roll it into a new release. |
This was referenced Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #10, #16, and #19. I also slightly redesigned the propensity recalculation logic, as it was recomputing some propensities multiple times in the same step, and it was also recomputing propensities even if only the product abundances changed.