More Mod Compat 6 #7320
Open
More Mod Compat 6 #7320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies to 1.20.1
# Conflicts: # src/generated/resources/.cache/b256105d8411632b0d585496ea8944a751a08034
- Update BYG/BWG compat (closes Creators-of-Create#7193)
IThundxr
added
the
pr type: feature
VoidLeech
reviewed
Feb 12, 2025
src/main/java/com/simibubi/create/foundation/data/recipe/MillingRecipeGen.java
Outdated
Show resolved
Hide resolved
src/main/java/com/simibubi/create/infrastructure/data/CreateRegistrateTags.java
Outdated
Show resolved
Hide resolved
VoidLeech
reviewed
Mar 1, 2025
| @@ -16,7 +16,8 @@ public enum Mods { | |||
| FA("forbidden_arcanus"), | |||
| HEX("hexcasting"), | |||
| ID("integrateddynamics", b -> b.strippedWoodIsSuffix()), | |||
| BYG("byg"), | |||
| BWG("biomeswevegone"), | |||
| BYG("biomeswevegone"), // TODO: Remove when CuttingRecipeGen is updated | |||
| .output(.125f, Items.NETHERRACK, 1) | ||
| .whenModLoaded(Mods.BYG.getId())), | ||
|
|
||
| BYG_RED_ROCK_ORE = create(Mods.BYG.recipeId("red_rock"), b -> b.duration(150) |
There was a problem hiding this comment.
As seen in the other PR, this recipe is still valid and can be updated instead of removed.
Edit as the lines are misplaced: the red rock one.
There was a problem hiding this comment.
https://github.com/Creators-of-Create/Create/blob/mc1.20.1/dev/src/generated/resources/data/create/recipes/milling/sandstone.json
Some parity for BWG's sandstones would be nice to have.
|
Oh and almost forgot. BWG's Palo Verde wood is crafted into Birch planks, so cutting recipes for the stripped ones into those would be nice as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update BYG/BWG compat (closes #7193)