Add config for diving helmet scaling render distance #7917
Conversation
| } | ||
| } | ||
| event.setCanceled(true); |
There was a problem hiding this comment.
The event.setCanceled call shouldn’t be moved out of the ifs, as that would cancel the event even if Create doesn’t do anything, which will break other mods. (Including Alex’s Caves’ own fog rendering for its fluids)
| @@ -322,17 +322,14 @@ public static void getFogDensity(ViewportEvent.RenderFog event) { | |||
|
|
|||
| ItemStack divingHelmet = DivingHelmetItem.getWornItem(entity); | |||
| if (!divingHelmet.isEmpty()) { | |||
| if (FluidHelper.isWater(fluid)) { | |||
| if (FluidHelper.isWater(fluid) && AllConfigs.server().equipment.shouldScaleWaterFogDistance.get()) { | |||
There was a problem hiding this comment.
I don’t think this is a very elegant way of solving your issue, as the diving helmet’s increased visibility will now not work in normal ocean biomes if this config is set.
Why is this a server config?
There was a problem hiding this comment.
I chose the config server, because the range of visibility is a gameplay element and an item property. I acted by analogy that if the subject had night vision, for example, I would take it to the config server.
If required, I will put it in the client config. But then in multiplayer, each player will have to turn off this property on their own.
There was a problem hiding this comment.
No that’s correct reasoning; but it should just be a biome tag instead as TropheusJ indicated.
VoidLeech
added
the
pr type: feature
|
this should be controlled by a biome tag, not a config |
Add a configuration for disabling diving helmet fog rendering scale. It can be useful for Alex's Caves' abyssal chasm biome, where the main feature is a very low render distance.
Before:
After: