Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.1] Processing Recipe Rework #7945

Open
wants to merge 18 commits into
base: mc1.21.1/dev
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
610ea20
ProcessingRecipe rework
RaymondBlaze Mar 14, 2025
0f5b8e7
Use chained MapCodec instead of manually implement encode and decode
RaymondBlaze Mar 14, 2025
ece3c09
Migrate JEI integration, fixes #8048
RaymondBlaze Mar 19, 2025
42d491c
Fix ProcessingRecipeParams' Codec
RaymondBlaze Mar 19, 2025
1f9425a
Fix SequencedAssemblyCategory rendering spout fluids
RaymondBlaze Mar 19, 2025
c2b2c2d
Skip fluid render for Spout with empty FluidStack
RaymondBlaze Mar 19, 2025
b344ee8
Fix ProcessingOutput not applying components
RaymondBlaze Mar 23, 2025
5a3718b
Optimize rollOutput for 100% chance case
RaymondBlaze Mar 23, 2025
06f044d
Add validation for ProcessingOutput's count and chance
RaymondBlaze Mar 24, 2025
3a8c6e8
Remove validation for chance bigger than 1 (Sequenced Assembly use th…
RaymondBlaze Mar 24, 2025
74b713c
Restore validation for ProcessingRecipe
RaymondBlaze Mar 24, 2025
83b058f
Revert "Remove validation for chance bigger than 1 (Sequenced Assembl…
RaymondBlaze Mar 24, 2025
4337500
Revert "Add validation for ProcessingOutput's count and chance"
RaymondBlaze Mar 24, 2025
a89eaf0
Revert "Optimize rollOutput for 100% chance case"
RaymondBlaze Mar 24, 2025
f3b82ee
Revert "Fix ProcessingOutput not applying components"
RaymondBlaze Mar 24, 2025
bcb2854
Revert "Skip fluid render for Spout with empty FluidStack"
RaymondBlaze Mar 24, 2025
fda524b
Revert "Fix SequencedAssemblyCategory rendering spout fluids"
RaymondBlaze Mar 24, 2025
c427758
Revert JEI visual optimization
RaymondBlaze Mar 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip fluid render for Spout with empty FluidStack
  • Loading branch information
RaymondBlaze committed Mar 19, 2025
commit c2b2c2d95d72f3a0dda52977e1f7bcd6f9a1b76a
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ public void draw(GuiGraphics graphics, int xOffset, int yOffset) {
.scale(scale)
.render(graphics);

if (fluid.isEmpty()) {
matrixStack.popPose();
return;
}

AnimatedKinetics.DEFAULT_LIGHTING.applyLighting();
matrixStack.pushPose();
UIRenderHelper.flipForGuiRender(matrixStack);
Expand Down