Crash on world gen with Oh the Biomes We've Gone in 1.20.1

[OxyMauron]

Tested with BWG 1.0.5-Beta and EE 3.2.4. Including log with a minimal mod set.

https://pastebin.com/1XYFrSTg

[AlexM2048]

Try this: https://www.curseforge.com/minecraft/mc-mods/feature-recycler

[sugan-reden]

Hi!
Just had this crash today that seems related, so I thought I'd bump this up too.
Not sure if it's necessary but, just in case, here's an additional crash log : https://gist.github.com/sugan-reden/ec7754ca3f998f55441cb2689d0017b1
Keep up the good work! And take care <3

P.S. Issue was also reported in BWG's repo. Here : Potion-Studios/Oh-The-Biomes-Weve-Gone#16

[JT122406]

Hello, I'm the main Developer of BWG and we are also getting a lot of reports on the load order error, I'm not sure who the lead dev is here but I would love to work with you on resolving this issue.

[Cristelknight999]

@JT122406 I already looked into it a bit. The issue with the 2 sakura forests is easily resolved (just two flowers used in a different order). The rest shouldn‘t be to hard to find with Cyanide.

Also I think it would be a good idea to make a list of the order of all vanilla features, that everyone creating biome mods should use. Because some orders aren‘t defined by vanilla Minecraft.

Edit: Accidentally closed the issue.

[JT122406]

@JT122406 I already looked into it a bit. The issue with the 2 sakura forests is easily resolved (just two flowers used in a different order). The rest shouldn‘t be to hard to find with Cyanide.

Also I think it would be a good idea to make a list of the order of all vanilla features, that everyone creating biome mods should use. Because some orders aren‘t defined by vanilla Minecraft.

Edit: Accidentally closed the issue.

That would be a good idea for a list like that to exist,
I was running into a issue regarding the seapickle/melon_patch feature but I have heard about the sakura one as well

[JT122406]

I seemed to have addressed the Sakura issue, still working on the seapickle/melon_patch

[JT122406]

I have fixed the incompat and will release a patch, this issue can be closed

[JT122406]

And the Sakura Fix causes a load order error with Terralith, It just never ends

[sugan-reden]

Hi, gentlepeople.
Thanks for working on this issue, it's nice to see.
A little while ago I had an issue with FOCs concerning flowers and biome gen.
At the time, the issue seemed to be an interaction with Cyclic and biome mods.

I do not know if this input will be useful to you but just in case here's the link to the issue, Lothrazar/Cyclic#2388
I thought it might provide ideas or references.

The issue was quickly given a fix by the kind @Apollounknowndev, creator of Tectonic, who has also done a lot of work on Terralith iirc.

Might they be able to help?

The fix was then incorporated in the mod later on by Lothrazar, after a long while.

[Cristelknight999]

@JT122406 that's why such a list would be a really good idea. I'll fix the Sakura issue on my end and you the sea Pickel one. Then everything should be fine for now (I hope)

[JT122406]

@JT122406 that's why such a list would be a really good idea. I'll fix the Sakura issue on my end and you the sea Pickel one. Then everything should be fine for now (I hope)

Honestly I'm just gonna remove the default flowers feature from it since the forest flowers has that type in it, save us all some headaches. Then it will work with everything

[Apollounknowndev]

Also I think it would be a good idea to make a list of the order of all vanilla features, that everyone creating biome mods should use. Because some orders aren‘t defined by vanilla Minecraft.

There is actually a master underlying list in the game, since biomes are sorted in a deterministic pattern.
https://gist.github.com/Apollounknowndev/a0846a6ce177d46df8ffaf045cef315b

While I would like to see this become a standard, I don't have the time or willpower to create PRs for every single biome mod :P

[sugan-reden]

While I would like to see this become a standard, I don't have the time or willpower to create PRs for every single biome mod :P

That's completely fair and understandable. I know you're a busy person.

I just thought you might at least have some insight to offer since you've dealt and worked through stuff that seemed related, at least to me, and you did!
Thanks a bunch :)

Also, thank you for having taken the time to leave a reply :) I appreciate it.

[JT122406]

@Cristelknight999 I patched the issue with EE but the change is now making a incompat with Overhauled Overworld

This is the fix for EE and this is the new error from Overhauled
Feature 'minecraft:seagrass_simple'
must be before 'minecraft:sea_pickle' (defined in 'minecraft:deep_lukewarm_ocean' at index 10, 11)
must be before 'minecraft:seagrass_normal' (defined in 'biomeswevegone:lush_stacks' at index 10, 11)
must be before 'minecraft:seagrass_simple' (defined in 'minecraft:ocean' at index 8, 9)
Which reversing my game fixes this error but readds the EE error

[JT122406]

Also weird but if I revert the change and use all 3 the world loads but if I use just EE and bwg I get Feature 'minecraft:patch_melon_sparse'
must be before 'biomeswevegone:oak_bushes' (defined in 'biomeswevegone:fragment_jungle' at index 8, 9)
must be before 'biomeswevegone:mushrooms' (defined in 'biomeswevegone:maple_taiga' at index 10, 18 and 8 others)
must be before 'minecraft:seagrass_normal' (defined in 'biomeswevegone:crag_gardens' at index 11, 12)
must be before 'minecraft:sea_pickle' (defined in 'biomeswevegone:lush_stacks' at index 10, 11)
must be before 'minecraft:patch_melon_sparse' (defined in 'minecraft:warm_ocean' at index 11, 12)

But fixing that with the new version i get the one in the message above with WWOO

[Cristelknight999]

@JT122406 probably because both WWOO and WWEE override vanilla biomes too.
I wrote a small java Programm to sort all features of all biomes of a mod by an list of features. We can probably use the list Apollo send. If we all use it it should resolve the issue. It just sorts the biome.json files directly so it isn‘t perfect.
I’m currently in school, but when I’m back home I’ll send it to you.

[JT122406]

@JT122406 probably because both WWOO and WWEE override vanilla biomes too. I wrote a small java Programm to sort all features of all biomes of a mod by an list of features. We can probably use the list Apollo send. If we all use it it should resolve the issue. It just sorts the biome.json files directly so it isn‘t perfect. I’m currently in school, but when I’m back home I’ll send it to you.

Awesome

[Cristelknight999]

Not going to happen today. had a long school day and the programm isn't 100% done

[Cristelknight999]

@JT122406 The first version of the Programm is finished and working.
It uses the list from @Apollounknowndev (thx for it) and sorts all biomes in a folder.

Currently you run the programm like this:
java -jar foc-1.0.jar
if you add no args it just searches the folder it's in for biomes and directly rewrites them correctly.

But you can also add things (which i didn't test at all):

• java -jar foc-1.0.jar C:/Users/Admin/Desktop/MyBiomeFolder does the same but in a different folder
• java -jar foc-1.0.jar C:/Users/Admin/Desktop/MyBiomeFolder C:/Users/Admin/Desktop/MyNewBiomeFolder reads from one folder and copies the new files in the second folder
• java -jar foc-1.0.jar * C:/Users/Admin/Desktop/MyNewBiomeFolder reads from the folder the jar file is in and copies the new files in the specified folder

If you have any ideas on what should be improved/changed please let me know. Also remember i didn't test this alot and the logging is really bad / not existing currently.
foc-1.0.zip

[JT122406]

@JT122406 The first version of the Programm is finished and working. It uses the list from @Apollounknowndev (thx for it) and sorts all biomes in a folder.

Currently you run the programm like this: java -jar foc-1.0.jar if you add no args it just searches the folder it's in for biomes and directly rewrites them correctly.

But you can also add arguments (which i didn't test at all):

• java -jar foc-1.0.jar C:/Users/Admin/Desktop/MyBiomeFolder does the same but in a different folder
• java -jar foc-1.0.jar C:/Users/Admin/Desktop/MyBiomeFolder C:/Users/Admin/Desktop/MyNewBiomeFolder reads from one folder and copies the new files in the second folder
• java -jar foc-1.0.jar * C:/Users/Admin/Desktop/MyNewBiomeFolder reads from the folder the jar file is in and copies the new files in the specified folder

If you have any ideas on what should be improved/changed please let me know. Also remember i didn't test this alot and the logging is really bad / not existing currently. foc-1.0.zip

Did you run it on wwoo and wwee?

[Cristelknight999]

@JT122406 Already updated WWEE. WWOO will follow soon

[JT122406]

@Cristelknight999 Sounds good, It made a lot of changes to bwg lol https://github.com/Potion-Studios/Oh-The-Biomes-Weve-Gone/tree/FeatureOrderStandardization
Making a branch since I need to go through and adjust the datagen to make the stuff look like this

[Cristelknight999]

@JT122406 Yeah. Glad it works! I updated it a bit with a few fixes and better logging. That will be the final version for now (i hope).
foc-1.1.zip

But no need to re-run it. No changes on how it works. Just some QOL and Performance enhancements.

[Cristelknight999]

Forgot to update the vanilla biomes in WWEE...

[Cristelknight999]

Just noticed some problems with WWEE. because the programm just sorts vanilla features some wwee feature creaete a feature order cycle error. that shouldn't happen often, but it is a thing i need to fix

[JT122406]

I have found an issue with the order I assume this would be something to ask @Apollounknowndev but

This change is made by the program but

These come together as one

[JT122406]

Also thinking about just making a Biome Dev discord so we can chat there and not have to go through github

[Cristelknight999]

@JT122406 good idea! Do you create the discord?

in the list from apollo these aren't together. I'm not totally sure why. Would be great if @Apollounknowndev could help.

[JT122406]

@Cristelknight999 @Apollounknowndev https://discord.gg/ybjmuuat

[SylisMC]

@Cristelknight999 @Apollounknowndev https://discord.gg/ybjmuuat

Is that open to public for stalking for updates?