fix(falcon_configure): control aid generation wait time and logic #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CrowdStrike#583 This PR should address concerns about potential timeouts or "misfires" around waiting for an AID to be generated on Linux systems (particularly on Ubuntu 20.04). We've added two ways to help mitigate these issues: 1. Use variables to control the retries/delays. Default to 60 seconds (6/10). 2. Use a block/rescue so that if the 1st attempt fails, we give it another try before concluding that something is wrong. We fail with a message that includes some troubleshooting steps.
redhatrises
previously approved these changes
Dec 12, 2024
carlosmmatos
force-pushed
the
carlosmmatos/issue583
branch
from
7c0d52a to
87e383f
Compare
After much discussion, this is a safer starting point. We will up the default amount of time to waiting for an AID to 2 minutes, but will still allow it to be customizable.
evanstoner
approved these changes
Dec 13, 2024
redhatrises
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #583
This PR should address concerns about potential timeouts or "misfires" around waiting for an AID to be generated on Linux systems (particularly on Ubuntu 20.04). We've added the following to help mitigate these issues: