Add (minimal) support for filtering #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…()` & `crosstabs()`
|
For what it's worth, I get the same errors the CI hit before my commit. |
Fixing a problem with babel related tests
|
Can you include an example in the FAQ. https://github.com/Crunch-io/crunchtabs/blob/main/vignettes/FAQ.Rmd? "How do I filter my data before creating a topline/crosstab report?" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A request came in through @malecki that a user wanted to be able to filter
crosstabs(), here's minimal support. I think probably the filtering information should be included in the output, but I'm not sure if that's required.Note that I have chosen to implement in a way that mirrors the rest of the crunch package, where the filter is pulled from the dataset. This means that behavior could change. I'm happy to ignore the dataset filter if you want that inconsistency.
Also I don't really get the testing strategy, so didn't add tests. I did confirm that filters work as expected manually.