Fix /condalock command
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was broken by a release of `urllib 2.x` which was incompatible with `cachecontrol`. A future release of `cachecontrol` may add this pin to its own dependencies or otherwise fix the incompatibility, at which time the hacky pin can be removed.
|
|
|
|
|
I don't think we can test this until it's merged. Should we merge this and then test it on the other open PR? Or is there a way to test GH Actions workflows on a branch? 🤔 |
weiji14
approved these changes
May 10, 2023
There was a problem hiding this comment.
Yes, let's merge this in first to test. Should be ok looking at the related thread at psf/cachecontrol#292.
|
I also tested installing the dependencies with that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was broken by a release of
urllib 2.xwhich was incompatible withcachecontrol. A future release ofcachecontrolmay add this pin to its own dependencies or otherwise fix the incompatibility, at which time the hacky pin can be removed.Closes #57