Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icepyx to v0.8.0 #97

Merged
merged 5 commits into from
Oct 25, 2023
Merged

update icepyx to v0.8.0 #97

merged 5 commits into from
Oct 25, 2023

Conversation

JessicaS11
Copy link
Contributor

@tsnow03 noted the hub image still used v0.7.0, which doesn't get s3 urls for all products.

@github-actions
Copy link

Binder 👈 Test this PR on Binder

@JessicaS11
Copy link
Contributor Author

/condalock

environment.yml Outdated Show resolved Hide resolved
@weiji14
Copy link
Member

weiji14 commented Oct 24, 2023

Hmm, there seems to be an unrelated build failure at https://github.com/CryoInTheCloud/hub-image/actions/runs/6632090917/job/18017023795?pr=97#step:5:6493

   Could not solve for environment specs
  The following packages are incompatible
  ├─ jupyter-book 0.13.2  is installable and it requires
  │  └─ myst-nb >=0.13.1,<0.14.0 , which requires
  │     └─ myst-parser ~=0.15.2 , which requires
  │        └─ mdit-py-plugins ~=0.2.8 , which requires
  │           └─ markdown-it-py ~=1.0  with the potential options
  │              ├─ markdown-it-py 1.0.0 would require
  │              │  └─ attrs >=19.3,<21 , which can be installed;
  │              └─ markdown-it-py 1.1.0 would require
  │                 └─ attrs >=19.3,<22 , which can be installed;
  └─ referencing is not installable because it requires
     └─ attrs >=22.2.0 , which conflicts with any installable versions previously reported.

Seems to be an upstream issue, reported at jupyter-book/jupyter-book#2044.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At L42, can you try upgrading jupyter-book to ~=0.15.1? That should get rid of the attrs dependency conflict.

JessicaS11 and others added 2 commits October 24, 2023 17:38
unrelated (to icepyx update) build failure
@weiji14
Copy link
Member

weiji14 commented Oct 24, 2023

/condalock

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JessicaS11!

@weiji14 weiji14 merged commit 0316973 into main Oct 25, 2023
1 check passed
@weiji14 weiji14 deleted the update_icepyx branch October 25, 2023 00:07
@JessicaS11
Copy link
Contributor Author

Thanks for the super fast review, @weiji14!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants