Added initial version and build to About view. Cleaned up SpiderOak l… #87
Conversation
…ogo on about view
|
The only thing I would add (havent built it yet) is a comment about app.kloak_version and app.build are properties in the un-checked-in www/js/configuration.js Also, change the kloak_version property to "public_version" |
|
Yeah that should be a README note in www/js/ maybe? |
|
@Bennyoak yeah, adding that to the README is a great idea |
| @@ -48,7 +48,7 @@ app.pauseEventHandler = function pauseEventHandler () { | |||
| app.aboutView = function _aboutView () { | |||
| var header = 'About Kloak'; | |||
| var logos = '<p><img class="app-logo" src="img/spideroak_logo.png" /> </p>'; | |||
| var info = 'Kloak is an <strong>*experiment*</strong> in social networking that is un-dataminable. All data sent to the server is "end to end" encrypted and unreadable by the server operator. <br /> Kloak is in beta and <strong>should not be used to hide communications from well-equipped potential attackers</strong> <p><a onclick="window.open(\'https://github.com/Crypton/statusapp\', \'_system\')" class="media-link media-link-url">Kloak issue tracker</a> <br />Kloak is built with <a onclick="window.open(\'https://crypton.io\', \'_system\')" class="media-link media-link-url">Crypton</a> by <a onclick="window.open(\'https://spideroak.com\', \'_system\')" class="media-link media-link-url">SpiderOak</a></p>'; | |||
| var info = '<span class="dist-info">Version: ' + app.kloak_version +'<br>Build: ' + app.build + '</span>Kloak is an <strong>*experiment*</strong> in social networking that is un-dataminable. All data sent to the server is "end to end" encrypted and unreadable by the server operator. <br /> Kloak is in beta and <strong>should not be used to hide communications from well-equipped potential attackers</strong> <p><a onclick="window.open(\'https://github.com/Crypton/statusapp\', \'_system\')" class="media-link media-link-url">Kloak issue tracker</a> <br />Kloak is built with <a onclick="window.open(\'https://crypton.io\', \'_system\')" class="media-link media-link-url">Crypton</a> by <a onclick="window.open(\'https://spideroak.com\', \'_system\')" class="media-link media-link-url">SpiderOak</a></p>'; | |||
There was a problem hiding this comment.
we should change app.kloak_version to app.app_version as well as add a section to the README about the existence of these required properties that should be in configuration.js
perhaps the best thing to do is add a section for "Configuration" in the readme where you display a sample configuration.js that has comments for each line?
There was a problem hiding this comment.
Other than that, I can merge this PR
…ogo on about view
Same thing as PR #82 but not configuration.js