Homepage UI fix #481
Open
Homepage UI fix #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -66,7 +66,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "start": "REACT_APP_VERSION=$(git describe --abbrev=0) REACT_APP_GIT_SHA=$(git rev-parse --short HEAD) react-scripts start", | |||
| "serve": "REACT_APP_VERSION=$(git describe --abbrev=0) REACT_APP_GIT_SHA=$(git rev-parse --short HEAD) BROWSER=none react-scripts start", | |||
| "serve": "react-scripts start", | |||
There was a problem hiding this comment.
please revert this change
src/components/Home/Banner/index.tsx
Outdated
| @@ -17,12 +19,15 @@ const Banner = (props: any) => { | |||
| <Holder> | |||
| <Title ref={props.actionBtnRef}>ARRONAX</Title> | |||
| <Text>Blockchain Analytics Tool </Text> | |||
| <LogoCon> | |||
| <Text> Brought to you by </Text> | |||
| <img src={CryptonomicLogo} alt="img"/> | |||
There was a problem hiding this comment.
set alt attribute to something like Brought to you by Cryptonomic
| </Button> | ||
|
|
||
| <BottomDiv> | ||
| <Title2>Discover Arronax</Title2> | ||
| <img src={DownArrow} alt="img"/> |
There was a problem hiding this comment.
alt, same here if you can
src/containers/Homepage/index.tsx
Outdated
| </Grid> | ||
| <Grid item xs={6}> | ||
| <img src={PlaceholderImage1} alt="img"/> | ||
| <AnchorTag className={classes.alignRight}> | ||
| <Link to={topBakersUrl}> | ||
| <AnchorTag style={{marginTop: '-7px'}} className={classes.alignRight}> |
There was a problem hiding this comment.
please set custom styles dynamically in AnchorTag or add in classes
src/containers/Homepage/index.tsx
Outdated
| <AnchorTag> | ||
| <Link to={{ pathname: "https://periscope.arronax.io/blocks?q=priorityBlocks"}} target="_blank" > | ||
| View Graph on Periscope | ||
| <svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
if possible please save svg as file in images and import to component
src/containers/Homepage/index.tsx
Outdated
| <Link to={topBakersUrl}> | ||
| <AnchorTag style={{marginTop: '-7px'}} className={classes.alignRight}> | ||
| <Link to={{ pathname: "https://harpoon.arronax.io/"}} target="_blank" > | ||
| View Baker Stats on Harpoon | ||
| <svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg"> |
src/containers/Homepage/index.tsx
Outdated
| <AnchorTag> | ||
| <Link to={{ pathname: "https://periscope.arronax.io/accounts"}} target="_blank" > | ||
| View Graph on Periscope | ||
| <svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg"> |
src/containers/Homepage/index.tsx
Outdated
| </Grid> | ||
| <Grid item xs={6}> | ||
| <img src={PlaceholderImage1} alt="img"/> | ||
| <img style={{marginBottom: '-18px'}} src={PlaceholderImage1} alt="img"/> |
There was a problem hiding this comment.
please pass margin bottom in class to avoid inline styles
dariuszsobkowicz
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.