Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merged introduction from concepts section into microservices SDK section #2634

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

BeateRixen
Copy link
Collaborator

As agreed on in this ticket https://cumulocity.atlassian.net/browse/MTM-61371 we want to move the content of https://cumulocity.com/docs/concepts/applications/ out of the concepts section.

The text in https://cumulocity.com/docs/concepts/applications/#microservices anyway was partly a duplicate of the text in here: https://cumulocity.com/docs/microservice-sdk/general-aspects/#introduction.

I tried to merge the texts into one.

Copy link
Contributor

Preview available here

@BeateRixen
Copy link
Collaborator Author

@rahulc8y @eickler @MWindel Please approve

@eickler
Copy link
Contributor

eickler commented Nov 19, 2024

@rahulc8y @nickponomar-c8y @BeateRixen I leave it to you if you see it in the scope of the PR, but this image in the introduction looks really odd to me, has no relationship to the text before and after, is not explained and has odd interpretation possibilities such as

  • Core consists only of API and database.
  • "Microservice ... 1" is somehow special compared to "Microservice ... n" and the others.
  • There is a link between 1 and the other instances of the microservices.
  • There is a link between Microservice B1 and Microservice X1.

I would have expected that this shows a bit about API gateway, tenancy and other functionalities that are discussed around it. We might even just delete it, maybe better no image than a misleading one.

microservice_infrastructure

@BeateRixen
Copy link
Collaborator Author

@rahulc8y What is your take on the image? Shall we remove it? Should I wait with merging this PR until the other files in this folder have also been moved and remove the entire section in one go?

@rahulc8y
Copy link
Collaborator

@nickponomar Hi Nick, I believe Andre's comments about the image are valid, but this is also more related to microservice hosting, since this isn't my area of expertise, I'd appreciate your review

@rahulc8y What is your take on the image? Shall we remove it? Should I wait with merging this PR until the other files in this folder have also been moved and remove the entire section in one go?

@nickponomar-c8y
Copy link
Contributor

@rahulc8y @nickponomar-c8y @BeateRixen I leave it to you if you see it in the scope of the PR, but this image in the introduction looks really odd to me, has no relationship to the text before and after, is not explained and has odd interpretation possibilities such as

  • Core consists only of API and database.
  • "Microservice ... 1" is somehow special compared to "Microservice ... n" and the others.
  • There is a link between 1 and the other instances of the microservices.
  • There is a link between Microservice B1 and Microservice X1.

I would have expected that this shows a bit about API gateway, tenancy and other functionalities that are discussed around it. We might even just delete it, maybe better no image than a misleading one.

microservice_infrastructure

I agree, the image is misleading, let's delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants