Blockchain: add alt-block handling #260
Conversation
github-actions
bot
added
A-storage
Boog900
force-pushed
the
storage-alt-blocks
branch
from
329a38b to
e1ae848
Compare
github-actions
bot
added
A-dependency
github-actions
bot
added
A-test-utils
Co-authored-by: hinto-janai <[email protected]>
| pub weight: u64, | ||
| pub weight: usize, |
There was a problem hiding this comment.
Is there a reason things are mostly usize instead of u64? Here but also across the codebase in general, e.g. DB service messages.
They are required to be u64 elsewhere (especially in RPC) and these usizes permeate and cause usize_to_u64() to be everywhere. I understand indices but these aren't that. Can we start using u64 instead?
There was a problem hiding this comment.
It's a trade of between what type is needed more, I used to use u64s everywhere but I changed it here: #201 and I do remember there being an improvement.
This is a weight which is often calculated by getting the size of a Vec, which is given in a usize. Plus you could change the JSON types to be usizes right?
There was a problem hiding this comment.
Changing this actually removed multiple conversions in the DB
There was a problem hiding this comment.
The types are defined as 64-bit in monerod, I don't think defining public fields within public RPC types as usize is a good tradeoff. Probably won't affect many machines but not worth it IMO. I'm okay with using the cast functions if these need to be usize elsewhere.
What
Adds alt block handling to the blockchain storage.
How
Follows #194