Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move consensus context service into a subcrate. #318

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Move consensus context service into a subcrate. #318

merged 1 commit into from
Oct 16, 2024

Conversation

SyntheticBird45
Copy link
Member

What

Address: #313

Move ContextService related modules in cuprate-consensus into a new cuprate-consensus-context crate.

@github-actions github-actions bot added A-dependency Related to dependencies, or changes to a Cargo.{toml,lock} file. A-workspace Changes to a root workspace file or general repo file. A-consensus Related to consensus. A-binaries Related to binaries. labels Oct 15, 2024
@SyntheticBird45
Copy link
Member Author

Will rebase once the tests pass

Boog900
Boog900 requested changes Oct 16, 2024
View reviewed changes
consensus/context/Cargo.toml Outdated Show resolved Hide resolved
consensus/src/block/alt_block.rs Outdated Show resolved Hide resolved
consensus/src/block/batch_prepare.rs Outdated Show resolved Hide resolved
@hinto-janai
Copy link
Contributor

Can you add this crate to here?: https://github.com/Cuprate/cuprate/blob/main/books/architecture/src/appendix/crates.md

@github-actions github-actions bot added A-docs Related to documentation. A-books Related to Cuprate's books. A-book-architecture Related to the Architecture book. labels Oct 16, 2024
Boog900
Boog900 requested changes Oct 16, 2024
View reviewed changes
consensus/src/tests/context.rs Outdated Show resolved Hide resolved
@SyntheticBird45 SyntheticBird45 force-pushed the split_consensus_context branch from cb18852 to d0b8454 Compare October 16, 2024 23:03
@Boog900 Boog900 merged commit 978d72b into main Oct 16, 2024
8 of 9 checks passed
@hinto-janai hinto-janai mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boog900 Boog900 Boog900 approved these changes

@hinto-janai hinto-janai Awaiting requested review from hinto-janai

Assignees
No one assigned
Labels
A-binaries Related to binaries. A-book-architecture Related to the Architecture book. A-books Related to Cuprate's books. A-consensus Related to consensus. A-dependency Related to dependencies, or changes to a Cargo.{toml,lock} file. A-docs Related to documentation. A-workspace Changes to a root workspace file or general repo file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SyntheticBird45 @hinto-janai @Boog900