lints: enable wildcard_imports

Cargo.toml

@@ -339,7 +339,7 @@ allow_attributes = "deny"
 # similar_names = "deny"
 # too_many_lines = "deny"
 # unreadable_literal = "deny"
-# wildcard_imports = "deny"
+wildcard_imports = "deny"
 # allow_attributes_without_reason = "deny"
 # missing_assert_message = "deny"
 # missing_docs_in_private_items = "deny"

consensus/rules/src/blocks.rs

@@ -3,7 +3,9 @@ use std::collections::HashSet;
 use crypto_bigint::{CheckedMul, U256};
 use monero_serai::block::Block;
 
-use cuprate_cryptonight::*;
+use cuprate_cryptonight::{
+    cryptonight_hash_r, cryptonight_hash_v0, cryptonight_hash_v1, cryptonight_hash_v2,
+};
 
 use crate::{
     check_block_version_vote, current_unix_timestamp,

helper/src/thread.rs

@@ -73,7 +73,9 @@ pub fn low_priority_thread() {
     #[cfg(target_os = "windows")]
     {
         use target_os_lib as windows;
-        use windows::Win32::System::Threading::*;
+        use windows::Win32::System::Threading::{
+            GetCurrentThread, SetThreadPriority, THREAD_PRIORITY_IDLE,
+        };
 
         // SAFETY: calling C.
         // We are _lowering_ our priority, not increasing, so this function should never fail.

net/epee-encoding/src/container_as_blob.rs

@@ -3,7 +3,10 @@ use alloc::{string::ToString, vec, vec::Vec};
 use bytes::{Buf, BufMut, Bytes, BytesMut};
 use ref_cast::RefCast;
 
-use crate::{error::*, EpeeValue, InnerMarker, Marker};
+use crate::{
+    error::{Error, Result},
+    EpeeValue, InnerMarker, Marker,
+};
 
 #[derive(RefCast)]
 #[repr(transparent)]

net/epee-encoding/src/io.rs

@@ -1,6 +1,6 @@
 use bytes::{Buf, BufMut};
 
-use crate::error::*;
+use crate::error::{Error, Result};
 
 #[inline]
 pub(crate) fn checked_read_primitive<B: Buf, R: Sized>(

net/epee-encoding/src/lib.rs

@@ -78,7 +78,7 @@ mod value;
 mod varint;
 
 pub use error::*;
-use io::*;
+use io::{checked_read, checked_read_primitive, checked_write, checked_write_primitive};
 pub use marker::{InnerMarker, Marker};
 pub use value::EpeeValue;
 pub use varint::{read_varint, write_varint};

net/epee-encoding/src/varint.rs

@@ -1,6 +1,6 @@
 use bytes::{Buf, BufMut};
 
-use crate::error::*;
+use crate::error::{Error, Result};
 
 const SIZE_OF_SIZE_MARKER: u32 = 2;
 const FITS_IN_ONE_BYTE: u64 = 2_u64.pow(8 - SIZE_OF_SIZE_MARKER) - 1;

net/wire/src/network_address.rs

@@ -24,7 +24,7 @@ use bytes::BufMut;
 use cuprate_epee_encoding::EpeeObject;
 
 mod epee_builder;
-use epee_builder::*;
+use epee_builder::TaggedNetworkAddress;
 
 #[derive(Debug, PartialEq, Eq, Clone, Copy)]
 pub enum NetZone {

net/wire/src/p2p.rs

@@ -29,9 +29,15 @@ pub mod admin;
 pub mod common;
 pub mod protocol;
 
-use admin::*;
+use admin::{
+    HandshakeRequest, HandshakeResponse, PingResponse, SupportFlagsResponse, TimedSyncRequest,
+    TimedSyncResponse,
+};
 pub use common::{BasicNodeData, CoreSyncData, PeerListEntryBase};
-use protocol::*;
+use protocol::{
+    ChainRequest, ChainResponse, FluffyMissingTransactionsRequest, GetObjectsRequest,
+    GetObjectsResponse, GetTxPoolCompliment, NewBlock, NewFluffyBlock, NewTransactions,
+};
 
 #[derive(Copy, Clone, Eq, PartialEq, Debug)]
 pub enum LevinCommand {

p2p/address-book/src/lib.rs

@@ -79,7 +79,7 @@ pub async fn init_address_book<Z: BorshNetworkZone>(
 
 use sealed::BorshNetworkZone;
 mod sealed {
-    use super::*;
+    use super::{NetZoneAddress, NetworkZone};
 
     /// An internal trait for the address book for a [`NetworkZone`] that adds the requirement of [`borsh`] traits
     /// onto the network address.

p2p/p2p-core/src/lib.rs

@@ -87,7 +87,9 @@ pub mod types;
 pub use error::*;
 pub use network_zones::{ClearNet, ClearNetServerCfg};
 pub use protocol::*;
-use services::*;
+use services::{
+    AddressBookRequest, AddressBookResponse, CoreSyncDataRequest, CoreSyncDataResponse,
+};
 //re-export
 pub use cuprate_helper::network::Network;
 pub use cuprate_wire::CoreSyncData;