-
Notifications
You must be signed in to change notification settings - Fork 41
DTMF support, native Go error wrapping, code cleanup, fixed example #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@Ulexus let me know if you want any change in the PR 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Lots of good stuff in here.
If you want to update the README, I think that's my only nit-ish objection. Thanks |
Done! I have removed the diff lines and left the note about DTMF. I will try to get the Asterisk patch merged now 😃 |
Hold on before merging please, I am working on the Asterisk PR, so the link to the patch might change. |
@florentchauveau are we still waiting for your Asterisk PR update, or is this ready to merge? |
The PR is getting discussed, I have fixed all of the reviewer comments. It took a bit of time to get it reviewed by someone. If it's not merged by the end of next week, I'll just provide a link to the branch on my repo, and we'll update the README again once the PR is merged? what do you think? |
Either way is fine; I'm not in a rush. I just saw that you had updated this PR since the last message, so I wanted to make sure you weren't waiting on me. |
The PR has been merged into master 🎉 I've updated the README as well. Thank you! |
Also, I think this library is stable enough for a |
No description provided.