Skip to content

DTMF support, native Go error wrapping, code cleanup, fixed example #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

florentchauveau
Copy link

No description provided.

@florentchauveau
Copy link
Author

@Ulexus let me know if you want any change in the PR 🙏

Copy link
Member

@Ulexus Ulexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Lots of good stuff in here.

@Ulexus
Copy link
Member

Ulexus commented Feb 28, 2025

If you want to update the README, I think that's my only nit-ish objection. Thanks

@florentchauveau
Copy link
Author

If you want to update the README, I think that's my only nit-ish objection. Thanks

Done! I have removed the diff lines and left the note about DTMF.

I will try to get the Asterisk patch merged now 😃

@florentchauveau
Copy link
Author

Hold on before merging please, I am working on the Asterisk PR, so the link to the patch might change.

@Ulexus
Copy link
Member

Ulexus commented Mar 21, 2025

@florentchauveau are we still waiting for your Asterisk PR update, or is this ready to merge?

@florentchauveau
Copy link
Author

@florentchauveau are we still waiting for your Asterisk PR update, or is this ready to merge?

The PR is getting discussed, I have fixed all of the reviewer comments. It took a bit of time to get it reviewed by someone.

If it's not merged by the end of next week, I'll just provide a link to the branch on my repo, and we'll update the README again once the PR is merged? what do you think?

@Ulexus
Copy link
Member

Ulexus commented Mar 21, 2025

Either way is fine; I'm not in a rush. I just saw that you had updated this PR since the last message, so I wanted to make sure you weren't waiting on me.

@florentchauveau
Copy link
Author

Either way is fine; I'm not in a rush. I just saw that you had updated this PR since the last message, so I wanted to make sure you weren't waiting on me.

The PR has been merged into master 🎉

I've updated the README as well. Thank you!

@florentchauveau
Copy link
Author

Also, I think this library is stable enough for a 1.0.0 release tag. But I'll let you decide on this!

@florentchauveau florentchauveau requested a review from Ulexus March 30, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants