-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: nvm tests
in envcontext.test.js
#1362
Conversation
Signed-off-by: Aryan Rajoria <[email protected]>
Signed-off-by: Aryan Rajoria <[email protected]>
nvm is a large bash function that only exists in the shell that loads the nvm.sh file. Some CI might make it difficult to load and execute all commands from the same shell. Can you share the circle CI configuration, so that we can see if any workarounds are possible? |
Signed-off-by: Aryan Rajoria <[email protected]>
Signed-off-by: Aryan Rajoria <[email protected]>
I test if nvm is available with So I believe this should not cause issues with CircleCi (these function are never meant to run in conditions where I would appreciate your feedback on whether this approach is acceptable or if I need to modify the tests. |
https://github.com/CycloneDX/cdxgen/actions/runs/10752403424/job/29820700978?pr=1362#step:56:20 |
Signed-off-by: Aryan Rajoria <[email protected]>
Signed-off-by: Aryan Rajoria <[email protected]>
Signed-off-by: Aryan Rajoria <[email protected]>
Signed-off-by: Aryan Rajoria <[email protected]>
Signed-off-by: Aryan Rajoria <[email protected]>
Waiting for repo tests to complete. We should look into biome to see why it is missing certain basic checks like variables undefined which are caught by eslint. The second category of such coding bugs in our project is missing await. |
This is a strange error for denotests which are not reproducible locally on Windows.
|
Fix
nvm tests
inenvcontext.test.js
.It should test the following functions:
getNvmToolDirectory
getOrInstallNvmTool
isNvmAvailable
there are some issues here as CircleCI does not actually have
nvm
but does haveNVM_DIR
inenv
.