Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extended support for Definitions #713

Merged
merged 22 commits into from
Feb 4, 2025

Conversation

hakandilek
Copy link
Contributor

@hakandilek hakandilek commented Oct 17, 2024

This PR builds on top of #701 to create extended elements for the bom.definitions.standards like:

depends on: #701
is part of: #696

@hakandilek hakandilek force-pushed the feat/bom.definitions-full branch 2 times, most recently from 19ea024 to 2d420c9 Compare October 17, 2024 16:29
@hakandilek hakandilek force-pushed the feat/bom.definitions-full branch 2 times, most recently from 18f2630 to 8145a51 Compare October 22, 2024 07:59
@jkowalleck jkowalleck added enhancement New feature or request schema 1.6 labels Oct 23, 2024
@hakandilek hakandilek force-pushed the feat/bom.definitions-full branch from 8145a51 to b362feb Compare October 28, 2024 08:17
cyclonedx/model/bom.py Outdated Show resolved Hide resolved
cyclonedx/model/definition.py Outdated Show resolved Hide resolved
cyclonedx/model/definition.py Outdated Show resolved Hide resolved
cyclonedx/model/definition.py Outdated Show resolved Hide resolved
cyclonedx/model/definition.py Outdated Show resolved Hide resolved
cyclonedx/model/definition.py Outdated Show resolved Hide resolved
cyclonedx/model/definition.py Outdated Show resolved Hide resolved
cyclonedx/model/definition.py Outdated Show resolved Hide resolved
@jkowalleck

This comment was marked as outdated.

@hakandilek hakandilek force-pushed the feat/bom.definitions-full branch from 1816586 to 4474bf4 Compare November 18, 2024 09:30
@hakandilek hakandilek marked this pull request as ready for review November 18, 2024 09:41
@hakandilek hakandilek requested a review from a team as a code owner November 18, 2024 09:41
@hakandilek
Copy link
Contributor Author

please rebase onto master.

Yes, rebased now.

@jkowalleck
Copy link
Member

thank you for all your efforts, @hakandilek .

there is no release planned for the rest of the year (except bug fixes, these are released without planning).
Therefore, i will postpone the review until January 2025.

I hope this is okay for you.

@hakandilek
Copy link
Contributor Author

i will postpone the review until January 2025.

@jkowalleck That's totally fine. Thanks for the information. I'll rebase this branch once more to keep it up to date.

@hakandilek hakandilek force-pushed the feat/bom.definitions-full branch from 4474bf4 to 467d7f7 Compare December 9, 2024 07:54
@jkowalleck
Copy link
Member

FYI: this is in review.

@jkowalleck jkowalleck self-requested a review January 15, 2025 12:13
@jkowalleck
Copy link
Member

I will take care of updates/merges, and the now-breaking tests.

Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck
Copy link
Member

jkowalleck commented Jan 15, 2025

i am in the middle of review,
and added some sprinkles here and there.

some tests are flaky, the sometimes fail, sometimes pass.
need to investigate deeper.

PS: reason found and fixed: #713 (comment)

@hakandilek
Copy link
Contributor Author

some tests are flaky, the somtimes fail, sometimes pass. need to investigate deeper.

Thanks for having a closer look. I've also spent no those flaky tests and was not able to locate the root-cause. Please let me know if I can add something.

Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck
Copy link
Member

review done.
LGTM

@jkowalleck jkowalleck merged commit 901dcdc into CycloneDX:main Feb 4, 2025
47 checks passed
@hakandilek
Copy link
Contributor Author

Thanks for working on the remaining bits and pieces

@jkowalleck
Copy link
Member

this was released via https://github.com/CycloneDX/cyclonedx-python-lib/releases/tag/v8.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request schema 1.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants