Fixed quick move stack actions in the storage terminal #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rubensworks
requested changes
May 1, 2023
...ava/org/cyclops/integratedterminals/client/gui/container/ContainerScreenTerminalStorage.java
Outdated
Show resolved
Hide resolved
...ava/org/cyclops/integratedterminals/client/gui/container/ContainerScreenTerminalStorage.java
Outdated
Show resolved
Hide resolved
...inals/core/terminalstorage/TerminalStorageTabIngredientComponentItemStackCraftingCommon.java
Outdated
Show resolved
Hide resolved
…andle quick move actions
…uickMoveStack to terminal menu superclass.
Snonky
force-pushed
the
storage-terminal-quickmovestack-fix
branch
from
79cba22 to
4ec6ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #18
Before
Notice how the vanilla double-click-with-a-stack transfers all items of a type but it doesn't work in the terminal.
terminal_before.mp4
After
With the fix, you are able to store all items of a type using the double click.
terminal_after.mp4
With inventory management mod
It also makes inventory management mods like MouseTweaks work with the terminal YaLTeR/MouseTweaks#68
terminal_tweaked.mp4
The fix
The pr implements
#quickMoveStackas suggested in #18. It also changes the way the terminal screen hands click events to its super class to make all quick move actions end up in the#quickMoveStackmethod.