Updated latest versions of OpenZeppelin contracts #7
Conversation
|
I'm going to leave this open until I upload a video to updraft telling people the version has changed. Thanks for making this PR |
| import {ERC20Permit, Nonces} from "@openzeppelin/contracts/token/ERC20/extensions/ERC20Permit.sol"; | ||
| import {ERC20Votes} from "@openzeppelin/contracts/token/ERC20/extensions/ERC20Votes.sol"; | ||
|
|
||
| contract GovernanceToken is ERC20, ERC20Permit, ERC20Votes { |
There was a problem hiding this comment.
@PatrickAlphaC @Akash-Kolekar - Can one of you please explain why we do this double inheritance, I've seen it before in the Proxy Lesson...
If GovernanceToken is extending / inheriting from ERC20Votes which inherits from ERC20 what's the need for the explicit inheritance of the ERC20 contract by the GovernanceToken contract?
There was a problem hiding this comment.
It's a bit redundant yes! But we need it to tell solidity what functions we are overriding below.
There was a problem hiding this comment.
But doesn't it already know? At compile time shouldn't the solc
Compiler know this without the explicit inheritance in the Governance Token.
Updated the latest version of the
Governance ContractsandOpenzeppelin contracts.Changed the version of the oz in
MakefileandReadMe