Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add XvB options, refactor & improve algorithm #11

Merged
merged 93 commits into from
Jul 24, 2024

Conversation

mostafaei2002
Copy link
Contributor

  • Add Simple/Advanced panels to XVB Tab
  • Manually set donation hashrate for xvb or p2pool

@Cyrix126
Copy link
Owner

Cyrix126 commented Jun 7, 2024

Changes needed to merge

UI:

Same UI for simple sub-menu

the UI for simple tab should not be different from before. The hero checkbox should not be replaced by a drop down menu.
The reason is that when you only have two choice a checkbox makes more sense since you need to make only one click instead of two to choose the other mode. Since Gupaxx is intended to be a easy to use GUI, this design detail is important.

keep XvB logo

The logo of XvB should not be removed as it is a link to the website easily seen. If there is not enough height space, you must add scroll bar.

Optional: Slider instead of input

Instead of having an input, a slider with % of HR or a number based on runtime xmrig would prevent user putting numbers above what their rig can offer.

Backend:

Pass all the CI checks

You can enable them for your branch by setting main to dev in .github/workflows/*.yml

@mostafaei2002 mostafaei2002 changed the title feat: manually donate or keep hashrates for xvb feat: modify XvB options, refactor & improve algorithm Jun 16, 2024
@Cyrix126 Cyrix126 changed the title feat: modify XvB options, refactor & improve algorithm feat: add XvB options, refactor & improve algorithm Jun 18, 2024
@Cyrix126 Cyrix126 merged commit b3c0e6e into Cyrix126:main Jul 24, 2024
13 checks passed
@mostafaei2002 mostafaei2002 deleted the dev branch August 4, 2024 17:21
Cyrix126 added a commit that referenced this pull request Feb 3, 2025
feat: add XvB options, refactor & improve algorithm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants