Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hyper from 0.14 to 1.3.1 #71

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

ruccho
Copy link
Contributor

@ruccho ruccho commented Jun 7, 2024

We would like to use http2_initial_max_send_streams() to resolve hyperium/h2#731 only included in hyper 1.3.0 and later.

In hyper 1.x, some breaking changes have been made:

  • Client is moved to hyper-util as client::legacy::Client.
  • Body is changed to be a trait and now implementations of Body is provided by http-body-util.

More details: https://hyper.rs/guides/1/upgrading/

Copy link
Member

@mayuki mayuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed response.
Thank you so much for undertaking the difficult task of migration! 🙏

It looks almost good, but please correct one typo.

@ruccho ruccho requested a review from mayuki June 17, 2024 10:10
Copy link
Member

@mayuki mayuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@mayuki mayuki merged commit d9ffe27 into Cysharp:main Jun 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: change the default value of initial_max_send_streams to 100
2 participants