This repository has been archived by the owner on Feb 21, 2022. It is now read-only.
Issue 155 #158
Open
Issue 155 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cud4m
requested review from
onmax,
svg153 and
alvarogtx300
and removed request for
onmax
onmax
reviewed
Mar 26, 2019
tickets/admin.py
Outdated
|
|
||
| ects_by_session = 2.0 / number_of_sessions | ||
|
|
||
| needed_talks = abs((maximum_ects - obj.ects) % ects_by_session) |
There was a problem hiding this comment.
method abs is unnecessary.
Modulo operation always return positive number.
Its not clear what obj.ects is.
onmax
reviewed
Mar 26, 2019
tickets/admin.py
Outdated
| while choosing: | ||
| chosen = random.choice(Session.objects.filter(edition__year=EDITION_YEAR,)) | ||
| if not CheckIn.objects.all().filter(attendant=obj, session=chosen).exists(): | ||
| print("roger") |
onmax
suggested changes
Mar 26, 2019
|
👍 |
alvarogtx300
approved these changes
May 14, 2019
|
What happened with this pr? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#155