Add missing query to dao-pre-propose-approver #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #766 +/- ##
==============================================
Coverage ? 96.26%
==============================================
Files ? 203
Lines ? 50093
Branches ? 0
==============================================
Hits ? 48221
Misses ? 1872
Partials ? 0 ☔ View full report in Codecov by Sentry. |
bekauz
reviewed
Nov 14, 2023
JakeHartnell
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dao-pre-propose-approvercontract does not currently provide any query to determine which pre-propose ID corresponds with a given proposal. In other words, you cannot check which pending proposal an approval proposal was made for.This PR adds a query
PendingProposalIdForApprovalProposalIdwhich takes theidof the approval proposal being voted on by the approval DAO and returns theidof the pending proposal in thedao-pre-propose-singlecontract on the DAO waiting for proposal approval.