Support both osmosis and CW tokenfactory msg standards #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahSaso
force-pushed
the
noah/support-cosmwasm-tokenfactory
branch
from
6197c96 to
66b34c8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #788 +/- ##
===============================================
- Coverage 96.50% 96.13% -0.37%
===============================================
Files 204 207 +3
Lines 52518 52716 +198
===============================================
Hits 50680 50680
- Misses 1838 2036 +198 ☔ View full report in Codecov by Sentry. |
NoahSaso
force-pushed
the
noah/support-cosmwasm-tokenfactory
branch
from
66b34c8 to
6096219
Compare
NoahSaso
force-pushed
the
noah/support-cosmwasm-tokenfactory
branch
from
6096219 to
f8f9071
Compare
NoahSaso
force-pushed
the
noah/support-cosmwasm-tokenfactory
branch
from
f8f9071 to
0c6eae1
Compare
Co-authored-by: Jake Hartnell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
/cosmwasm.tokenfactorymsg type URLs tocw-tokenfactory-issuer, now supporting both/cosmwasm.and/osmosis.. The feature flagosmosis_tokenfactoryorcosmwasm_tokenfactorycontrol which version of the contract gets built.It also removes dependency on the
token_bindingspackage which usesCosmosMsg::Custom(TokenFactoryMsg)because we now use stargate (CosmosMsg::Stargate) messages instead, which are supported on all chains since msgs are protobuf encoded. This is critical to supporting both token thecosmwasm.andosmosis.tokenfactory standards.