Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cw-orch improvements #880

Merged

Conversation

ismellike
Copy link
Contributor

@ismellike ismellike commented Sep 10, 2024

Uses fn_name attribute for proposal modules' execute

https://orchestrator.abstract.money/contracts/entry-points.html?highlight=rename#fn_name-attribute
Following the same naming as already done in dao-proposal-sudo

Updates osmosis-test-tube to match cw-orch

Fixes prost schema mismatches resulting in the following errors when uploading wasms:

Error: Generic Error execute error: [{"events":[{"type":"message","attributes":[{"key":"action","value":"/cosmwasm.wasm.v1.MsgStoreCode"},{"key":"module","value":"wasm"},{"key":"sender","value":"osmo1smhn2tugxw4ccjrqv6mezwjm04mqma2llppddx"}]},{"type":"store_code","attributes":[{"key":"code_checksum","value":"854f6d014e90b4e7671619271514461cfbf371e981463a6daf5d1c803273919f"},{"key":"code_id","value":"1"}]}]}]

image

@ismellike ismellike changed the title Added cw_orch fn_name for proposal executes cw-orch improvements Sep 18, 2024
@NoahSaso NoahSaso merged commit 1964fd3 into DA0-DA0:feature/cw-orch-interface Oct 31, 2024
4 checks passed
@NoahSaso NoahSaso self-requested a review October 31, 2024 04:32
Copy link
Member

@NoahSaso NoahSaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants