-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove cw721 claim limit, and upgrade to v2.6.0 #893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahSaso
force-pushed
the
noah/make-nft-claims-paginatable
branch
2 times, most recently
from
October 31, 2024 02:15
5e6f3b0
to
815717d
Compare
NoahSaso
force-pushed
the
noah/make-nft-claims-paginatable
branch
from
October 31, 2024 06:36
815717d
to
04ba37e
Compare
NoahSaso
force-pushed
the
noah/make-nft-claims-paginatable
branch
from
October 31, 2024 17:17
daccce4
to
ed90960
Compare
NoahSaso
changed the title
remove cw721 claim limit
remove cw721 claim limit, and upgrade to v2.6.0
Oct 31, 2024
ismellike
suggested changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I think it's just missing checks to ensure we don't have claims in both systems. Other suggestions are mainly for clarity and better API.
NoahSaso
force-pushed
the
noah/make-nft-claims-paginatable
branch
from
October 31, 2024 22:46
ec6172e
to
195da14
Compare
ismellike
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this rewrites the NFT claims logic to make it paginate-able, removing the limit on how many outstanding claims can exist simultaneously
it is backwards compatible by introducing a new state map, seamlessly integrating with the legacy NFT claims so that DAOs can migrate without hassle
specific changes:
Map<(address, token_id) -> release_at>
that can be infinitely paginated, thereby removing any limit on outstanding claimstoken_ids
list, or a specific set oftoken_ids
. no argument will attempt to claim all outstanding legacy claims. an emptytoken_ids
list attempts to claim all non-legacy claims, and it will simply fail if there are too many for one transaction. and a specific set oftoken_ids
will attempt to claim just those outstanding non-legacy claims. ideally, we are always specifying the exact tokens to claim, and the frontend can automatically batch as necessarystart_after
andlimit
) only apply to the non-legacy claims