fixed proposal ID error

DA0-DA0 · May 11, 2024 · 1a75ac2 · 1a75ac2
1 parent 64d69cd
commit 1a75ac2
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/src/data/formulas/contract/neutron/cwdSubdaoTimelockSingle.ts b/src/data/formulas/contract/neutron/cwdSubdaoTimelockSingle.ts
@@ -7,7 +7,7 @@ export const config: ContractFormula = {
 
 export const proposal: ContractFormula<any, { id: string }> = {
   compute: async ({ contractAddress, get, args: { id } }) => {
-    if (!id) {
+    if (!id || isNaN(Number(id)) || Number(id) < 0) {
       throw new Error('missing `id`')
     }
 
@@ -51,7 +51,7 @@ export const listProposals: ContractFormula<
 
 export const proposalExecutionError: ContractFormula<any, { id: string }> = {
   compute: async ({ contractAddress, get, args: { id } }) => {
-    if (!id) {
+    if (!id || isNaN(Number(id)) || Number(id) < 0) {
       throw new Error('missing `id`')
     }
 

diff --git a/src/data/formulas/contract/prePropose/daoPreProposeApprovalSingle.ts b/src/data/formulas/contract/prePropose/daoPreProposeApprovalSingle.ts
@@ -41,7 +41,7 @@ export const proposalCreatedAt: ContractFormula<
     getDateKeyFirstSet,
     args: { id },
   }) => {
-    if (!id) {
+    if (!id || isNaN(Number(id)) || Number(id) < 0) {
       throw new Error('missing `id`')
     }
 
@@ -70,7 +70,7 @@ export const proposalCompletedAt: ContractFormula<
     getDateKeyFirstSet,
     args: { id },
   }) => {
-    if (!id) {
+    if (!id || isNaN(Number(id)) || Number(id) < 0) {
       throw new Error('missing `id`')
     }
 
@@ -98,7 +98,7 @@ export const proposal: ContractFormula<Proposal | undefined, { id: string }> = {
       args: { id },
     } = env
 
-    if (!id) {
+    if (!id || isNaN(Number(id)) || Number(id) < 0) {
       throw new Error('missing `id`')
     }
 
@@ -319,7 +319,7 @@ export const completedProposalIdForCreatedProposalId: ContractFormula<
     get,
     args: { id },
   }) => {
-    if (!id) {
+    if (!id || isNaN(Number(id)) || Number(id) < 0) {
       throw new Error('missing `id`')
     }
 

diff --git a/src/data/formulas/contract/prePropose/daoPreProposeApprover.ts b/src/data/formulas/contract/prePropose/daoPreProposeApprover.ts
@@ -12,7 +12,7 @@ export const preProposeApprovalIdForApproverProposalId: ContractFormula<
   { id: string }
 > = {
   compute: async ({ contractAddress, get, args: { id } }) => {
-    if (!id) {
+    if (!id || isNaN(Number(id)) || Number(id) < 0) {
       throw new Error('missing `id`')
     }
 
@@ -25,7 +25,7 @@ export const approverProposalIdForPreProposeApprovalId: ContractFormula<
   { id: string }
 > = {
   compute: async ({ contractAddress, get, args: { id } }) => {
-    if (!id) {
+    if (!id || isNaN(Number(id)) || Number(id) < 0) {
       throw new Error('missing `id`')
     }
 

diff --git a/src/data/formulas/contract/proposal/daoProposalMultiple/formulas.ts b/src/data/formulas/contract/proposal/daoProposalMultiple/formulas.ts
@@ -33,7 +33,7 @@ export const proposal: ContractFormula<
       args: { id },
     } = env
 
-    if (!id) {
+    if (!id || isNaN(Number(id)) || Number(id) < 0) {
       throw new Error('missing `id`')
     }
 
@@ -321,7 +321,7 @@ export const proposalCreatedAt: ContractFormula<
     getDateKeyFirstSet,
     args: { id },
   }) => {
-    if (!id) {
+    if (!id || isNaN(Number(id)) || Number(id) < 0) {
       throw new Error('missing `id`')
     }
 

diff --git a/src/data/formulas/contract/proposal/daoProposalSingle/formulas.ts b/src/data/formulas/contract/proposal/daoProposalSingle/formulas.ts
@@ -34,7 +34,7 @@ export const proposal: ContractFormula<
       args: { id },
     } = env
 
-    if (!id) {
+    if (!id || isNaN(Number(id)) || Number(id) < 0) {
       throw new Error('missing `id`')
     }
 
@@ -373,7 +373,7 @@ export const proposalCreatedAt: ContractFormula<
     getDateKeyFirstSet,
     args: { id },
   }) => {
-    if (!id) {
+    if (!id || isNaN(Number(id)) || Number(id) < 0) {
       throw new Error('missing `id`')
     }