Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ruff instead of Black+isort+Flake8 #1089

Merged
merged 10 commits into from
Aug 9, 2024

Conversation

Dev-iL
Copy link
Contributor

@Dev-iL Dev-iL commented Aug 8, 2024

Ruff is faster, and some might say more modern, alternative to multiple other tools.

Changes

(See individual commit titles)

How I tested this

Evaluated the pre-commit hooks until they passed.

Notes

As discussed on Slack, some inspections, when enabled (or unexcluded), detect a lot of violations, so enabling rules and rule families will need to be done carefully. This will require an additional effort, potentially outside the scope of this PR.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@Dev-iL Dev-iL force-pushed the Dev-iL/2408/enable-ruff branch 7 times, most recently from dbc7060 to 837858d Compare August 9, 2024 08:48
@Dev-iL Dev-iL force-pushed the Dev-iL/2408/enable-ruff branch from 837858d to a1f679e Compare August 9, 2024 08:55
@Dev-iL Dev-iL marked this pull request as ready for review August 9, 2024 16:50
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

@skrawcz skrawcz merged commit f35f6b7 into DAGWorks-Inc:main Aug 9, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants