-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to enable RayGraphAdapter and HamiltonTracker to work well together #1103
Merged
elijahbenizzy
merged 33 commits into
DAGWorks-Inc:main
from
jernejfrank:ray-remote-hooks
Sep 9, 2024
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
74b152b
Update graph_functions.py
elijahbenizzy 41decaa
Adds comments to lifecycle base
elijahbenizzy 5b73b8f
Update h_ray.py with comments for ray tracking compatibility
elijahbenizzy aa3ac05
Replicate previous error
e519180
Inline function, unsure if catching errors and exceptions to be handa…
2dca334
BaseDoRemoteExecute has the added Callable function that snadwisched …
04f1a1b
method fails, says AssertionError about ray.remote decorator
b77860e
simple script for now to check telemetry, execution yield the ray.rem…
c8358f8
passing pointer through and arguments to lifecycle wrapper into ray.r…
e77f6f7
post-execute hook for node not called
f7e81a0
finally executed only when exception occurs, hamilton tracker not exe…
3a1cccd
atexit.register does not work, node keeps running inui
09b47de
added stop() method, but doesn't get called
933991f
Ray telemtry works for single node, problem with connected nodes
d1e6ea0
Ray telemtry works for single node, problem with connected nodes
b528a45
Ray telemtry works for single node, problem with connected nodes
7acdd38
Fixes ray object dereferencing
skrawcz 377dc71
ray works checkpoint, pre-commit fixed
8e3eacd
fixed graph level telemtry proposal
5aa592b
pinned ruff
36e8fcb
Correct output, added option to start ray cluster
f17d4f2
Unit test mimicks the DoNodeExecute unit test
abd87f7
Refactored driver so all tests pass
4e28677
Workaround to not break ray by calling init on an open cluster
d9e86a9
raw_execute does not have post_graph_execute and is private now
6953417
Correct version for depraction warning
e988db5
all tests work
51c8544
this looks better
3acd95c
ruff version comment
a556558
Refactored pre- and post-graph-execute hooks outside of raw_execute w…
c1b55ee
added readme, notebook and made script cli interactive
089d1de
made cluster init optional through inserting config dict
1985ef7
User has option to shutdown ray cluster
jernejfrank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
pinned ruff
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.